pod search should list versions in version order, not lexicographic order

[RepublicOfAppsLLC]

Try

shell> pod search
-> Facebook-iOS-SDK (3.13.0)
   The iOS SDK provides Facebook Platform support for iOS apps.
   pod 'Facebook-iOS-SDK', '~> 3.13.0'
   - Homepage: https://developers.facebook.com/docs/ios/
   - Source:   https://github.com/facebook/facebook-ios-sdk.git
   - Versions: 3.9.0, 3.8.0, 3.7.1, 3.7.0, 3.6.0, 3.5.3, 3.5.2, 3.5.1, 3.5.0, 3.2.1, 3.2.0, 3.13.0, 3.12.0, 3.11.1, 3.11.0, 3.10.0, 3.1.1, 3.1.0, 3.0.8, 3.0.7, 3.0.6.b, 3.0.5.b, 1.last, 1.2, 0.0.1 [master repo]

Note how the leftmost version listed in the Versions line is 3.9.0 when in fact the latest version is actually 3.13.0.

A human is going to look at the Versions line and assume the most recent version is on the left. Nobody is going to assume that they need nor wlll they want to scan the whole line and pick out the latest version.

I realize that the latest version is shown in parentheses in the top title of the podspec listing

-> Facebook-iOS-SDK (3.13.0)

However, it seems like listing the Versions line in lexicographic order is a bug and makes no sense since the natural and correct way to think about versions is by their actual domain ordering, which would place versions in a strict ordering from, preferably, latest on the left to oldest on the right.

I'd be happy to take a look at fixing this if you can give me a pointer where to look in the code.

Thanks!

Joel

[fabiopelosin]

👍

The approximative stack trace is the following:

• https://github.com/CocoaPods/CocoaPods/blob/master/lib/cocoapods/user_interface.rb#L170
• https://github.com/CocoaPods/Core/blob/master/lib/cocoapods-core/specification/set/presenter.rb#L60
• https://github.com/CocoaPods/Core/blob/master/lib/cocoapods-core/specification/set/presenter.rb#L62

Another place where this issue should be fixed is:

• https://github.com/CocoaPods/Core/blob/master/lib/cocoapods-core/specification/set/presenter.rb#L47

According to the documentation versions are represented in the Pod::Version class which should take care of properly setting the sorting behaviour:

• https://github.com/CocoaPods/Core/blob/master/lib/cocoapods-core/version.rb#L33
• https://github.com/CocoaPods/Core/blob/master/lib/cocoapods-core/vendor/version.rb#L307

If you submit a patch please update the changelog crediting yourself and mentioning this issue and provide adequate testing... feel free to ask if you need any clarification.

[CocoaPodsBot]

Issue has been confirmed by @neonichu