Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.34.1 is not using shallow clones for the Master specs repo #2586

Closed
endocrimes opened this issue Oct 3, 2014 · 5 comments
Closed

0.34.1 is not using shallow clones for the Master specs repo #2586

endocrimes opened this issue Oct 3, 2014 · 5 comments
Labels
d1:easy An easy ticket that is a good start for first-time contributors s3:detailed Issues with in-depth explanations and examples that make it easier to troubleshoot t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!

Comments

@endocrimes
Copy link
Member

$ pod install --verbose
  Preparing

Analyzing dependencies

Updating spec repositories
  $ /opt/boxen/homebrew/bin/git rev-parse  >/dev/null 2>&1
Updating spec repo `master`
  $ /opt/boxen/homebrew/bin/git pull --ff-only

with sources defined as:

source 'https://github.com/CocoaPods/Specs.git'
@kylef kylef added d1:easy An easy ticket that is a good start for first-time contributors s3:detailed Issues with in-depth explanations and examples that make it easier to troubleshoot t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome! labels Oct 3, 2014
@segiddins
Copy link
Member

@DanielTomlinson what was the output in 0.33.1?

@kylef
Copy link
Contributor

kylef commented Oct 3, 2014

pod setup still has it right. When the source directive was introduced, the logic to make it depth 1 if it's master was missing.

$ pod setup --verbose

Setting up CocoaPods master repo

Creating shallow clone of spec repo `master` from `https://github.com/CocoaPods/Specs.git` (branch `master`)
  $ /usr/local/bin/git clone 'https://github.com/CocoaPods/Specs.git' master
  --depth=1
  Cloning into 'master'...

@segiddins
Copy link
Member

Output of pod install from 0.33.1:

Updating spec repo `master`
  $ /usr/local/bin/git pull --ff-only
  From https://github.com/CocoaPods/Specs
     10955ae..2ab3027  master     -> origin/master
  First, rewinding head to replay your work on top of it...
  Fast-forwarded master to 2ab30278446c1049af20c69dad846b5cae7f371e.

Therefore, I'm inclined to think that this is behavior that was not introduced by the changes with the source directive in 0.34.

@kylef
Copy link
Contributor

kylef commented Oct 5, 2014

@segiddins You've pasted the output of updating the repository and not cloning as per the issue title.

$ pod install --verbose
Analyzing dependencies

Updating spec repositories

Cloning spec repo `master` from `https://github.com/CocoaPods/Specs`
  $ /usr/local/bin/git clone 'https://github.com/CocoaPods/Specs' master

One thing though, without #2563 merged pod setup is ran first so you can't yet get into this state.

@segiddins
Copy link
Member

@kylef I was merely mimicking the command run in the initial comment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d1:easy An easy ticket that is a good start for first-time contributors s3:detailed Issues with in-depth explanations and examples that make it easier to troubleshoot t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Projects
None yet
Development

No branches or pull requests

3 participants