Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying resources for Watch Extensions need to go to the Watch App #4275

Closed
michaelochs opened this issue Sep 28, 2015 · 7 comments
Closed
Labels
s1:awaiting input Waiting for input from the original author s2:confirmed Issues that have been confirmed by a CocoaPods contributor t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!

Comments

@michaelochs
Copy link

When adding a pod that contains resources to a Watch Extension, these resources need to be copied to the Watch App instead of the Watch Extension.

Two potential systems of doing that come to my mind:
a) There needs to be an instruction in the Podfile that links watch extensions to its corresponding watch apps. (There can be multiple of both due to watchOS 1 and watchOS 2 apps/extensions.)
b) You simply add the same pod to both, the watch extension and the watch app and cocoa pods needs to ensure that for the watch app no framework or library will be linked and for the watch extension no resources will be copied.

Note: This issue is related to #4178 as copying resources to an extension will break the archive process of Xcode.

@neonichu
Copy link
Member

I think we can determine the relationship between watch app and extension from the user project itself.

@neonichu neonichu added s2:confirmed Issues that have been confirmed by a CocoaPods contributor t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome! labels Sep 28, 2015
@michaelochs
Copy link
Author

That would be the best solution if this is possible. Haven't looked into the build settings, but e.g. in our App we have two watch apps with the same bundle identifier (watchOS 1 and watchOS 2) and two watch extensions with different bundle identifiers. But I guess it is possible somehow as iOS is able to check that as well...

@neonichu
Copy link
Member

Seems like the link between them is established via the IBSC_MODULE build setting in the watch app, which contains the module name of the corresponding watch extension. I'm assuming this has to be unique?

@segiddins
Copy link
Member

@neonichu there can be multiple targets with the same module name that have different built product names?

@jcampbell05
Copy link
Collaborator

@segiddins Could you not look at the dependencies or build phases ? i.e If a watch app embeds an extension or has that extension as a dependency then they are related :)

@segiddins
Copy link
Member

I had a branch that tried to do it but @neonichu talked me out of it

@stale stale bot added the s1:awaiting input Waiting for input from the original author label May 24, 2017
@stale
Copy link

stale bot commented May 24, 2017

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

@stale stale bot closed this as completed Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s1:awaiting input Waiting for input from the original author s2:confirmed Issues that have been confirmed by a CocoaPods contributor t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Projects
None yet
Development

No branches or pull requests

4 participants