Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving logic so incomplete downloads aren't cached #6454

Closed
1 task done
karagraysen opened this issue Jan 31, 2017 · 6 comments
Closed
1 task done

Improving logic so incomplete downloads aren't cached #6454

karagraysen opened this issue Jan 31, 2017 · 6 comments
Labels
d2:moderate A moderately-difficult ticket that may require a bit of knowledge about the codebase s3:detailed Issues with in-depth explanations and examples that make it easier to troubleshoot t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!

Comments

@karagraysen
Copy link

karagraysen commented Jan 31, 2017

🌈

A Realm user filed an issue on Realm-Cocoa explaining that one of our files (collection_notifications.hpp) could not be found. The specific issue can be found here: realm/realm-swift#4614.

To summarize it:

  • The user has CocoaPods version 1.1.1 installed.
  • pod update failed with this message:
Installing Realm (2.4.2)
[!] /bin/bash -c
set -e 
sh build.sh cocoapods-setup

core is not a symlink. Deleting...
Downloading dependency: sync 1.0.1
Downloading sync failed:
curl: (56) SSLRead() return error -36
  • The user claims their internet connection was unstable at the time.
  • The user tried again later when their connection was stable but the files weren't fixed.
  • The user mentioned the following script fixed the issue for them:
#!/usr/bin/env bash

rm -rf "${HOME}/Library/Caches/CocoaPods"
rm -rf "`pwd`/Pods/"
pod update

I'm not experienced in this area but is it possible for CocoaPods to improve the logic where downloads occur so incomplete downloads aren't cached in a problematic way?

Please let me know if there's anything else I can provide. ❤️

@benasher44
Copy link
Member

@istx25 thanks for the report! This definitely sounds like a bad cache type of issue. I can't guarantee when someone will get to fixing this, but I'll make sure that this issue is labeled appropriately!

@benasher44 benasher44 added d2:moderate A moderately-difficult ticket that may require a bit of knowledge about the codebase s3:detailed Issues with in-depth explanations and examples that make it easier to troubleshoot t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome! labels Mar 11, 2017
@stale stale bot added the s1:awaiting input Waiting for input from the original author label Jun 9, 2017
@stale
Copy link

stale bot commented Jun 9, 2017

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

@stale stale bot removed the s1:awaiting input Waiting for input from the original author label Jun 9, 2017
@karagraysen
Copy link
Author

There's nothing more for me to add. All information should be there and it's just in backlog until someone in the CocoaPods team can get around to fix it.

@dnkoutso
Copy link
Contributor

dnkoutso commented Jun 10, 2017

@istx25 was that part of executing a prepare_command or downloading the actual source (zip perhaps) of the pod?

The reason I am asking is because this issue exists #4587 which might be similar and if solved will solved this issue here as well.

@karagraysen
Copy link
Author

I'm not sure. I'd recommend looking at the original issue on the Realm organization that I linked above. I no longer work at Realm so if you need more information, I recommend reaching out on the original issue and trying to talk to others who work there. Cheers

@dnkoutso
Copy link
Contributor

@istx25 thanks, from checking the podspec this seems the same issue where the prepare_command failed and possibly continued and so it never ran again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d2:moderate A moderately-difficult ticket that may require a bit of knowledge about the codebase s3:detailed Issues with in-depth explanations and examples that make it easier to troubleshoot t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Projects
None yet
Development

No branches or pull requests

3 participants