Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show a warning about using HTTP sources from localhost #8156

Closed
Corrob opened this issue Oct 3, 2018 · 7 comments
Closed

Don't show a warning about using HTTP sources from localhost #8156

Corrob opened this issue Oct 3, 2018 · 7 comments
Assignees
Labels
d1:easy An easy ticket that is a good start for first-time contributors t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it
Milestone

Comments

@Corrob
Copy link

Corrob commented Oct 3, 2018

My team does some testing with pods that are hosted locally. However, we see the warning:

The URL (<localhost_url>) doesn't use the encrypted HTTPs protocol. It is crucial for Pods to be transferred over a secure protocol to protect your users from man-in-the-middle attacks. This will be an error in future releases. Please update the URL to use https.

Can update this check to be alright with HTTP when the host is localhost. I don't think we have to worry about man-in-the-middle attacks in this case, and needing to use HTTPS adds complications for testing.

Thanks!

@dnkoutso
Copy link
Contributor

dnkoutso commented Oct 4, 2018

Are you using these pods as local pods only? If so, why not prepend it with https since they are never published?

@dnkoutso dnkoutso added the s1:awaiting input Waiting for input from the original author label Oct 4, 2018
@Corrob
Copy link
Author

Corrob commented Oct 4, 2018

Thanks for the fast response! Yes, this is only for local testing purposes.

If it was as easy as adding https to the URL, that would be great. Unfortunately, getting a local server to support HTTPS requires jumping through some hoops: https://stackoverflow.com/questions/43677457/how-to-create-a-https-server-on-localhost.

@stale stale bot removed the s1:awaiting input Waiting for input from the original author label Oct 4, 2018
@dnkoutso
Copy link
Contributor

dnkoutso commented Oct 4, 2018

@Corrob for pods consumed locally the source is not cloned or accessed therefore you should be OK to change this.

You will only be able to consume the pod with pod 'MyPod', :path => '/path/to/file.podspec' which as I understand you do.

@dnkoutso dnkoutso added the s1:awaiting input Waiting for input from the original author label Oct 4, 2018
@Corrob
Copy link
Author

Corrob commented Oct 4, 2018

This is probably a weird setup, but we have some general infrastructure for testing binary pods that are served through a local server.

We test it with a Podfile like:

source 'http://localhost:<port>/<path>/.git'
pod '<pod_under_test>'

@stale stale bot removed the s1:awaiting input Waiting for input from the original author label Oct 4, 2018
@segiddins
Copy link
Member

That sounds reasonable to me

@dnkoutso dnkoutso added t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it d1:easy An easy ticket that is a good start for first-time contributors labels Oct 4, 2018
@dnkoutso
Copy link
Contributor

dnkoutso commented Oct 4, 2018

@Corrob should be fairly easy to make a PR to add this. I've marked it as such.

@dnkoutso dnkoutso closed this as completed Oct 4, 2018
@dnkoutso dnkoutso reopened this Oct 4, 2018
@dnkoutso
Copy link
Contributor

dnkoutso commented Oct 4, 2018

Accidental close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d1:easy An easy ticket that is a good start for first-time contributors t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it
Projects
None yet
Development

No branches or pull requests

4 participants