Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successful pod install not generating Podfile.lock #9288

Closed
1 task done
mokagio opened this issue Oct 25, 2019 · 5 comments · Fixed by #9298
Closed
1 task done

Successful pod install not generating Podfile.lock #9288

mokagio opened this issue Oct 25, 2019 · 5 comments · Fixed by #9298
Labels
d1:easy An easy ticket that is a good start for first-time contributors t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Milestone

Comments

@mokagio
Copy link

mokagio commented Oct 25, 2019

Report

What did you do?

Running pod install on this Podfile succeeds, but no Podfile.lock is generated.

install! 'cocoapods',
  integrate_targets: false,
  skip_pods_project_generation: true

platform :ios, '13.0'

pod 'SwiftFormat/CLI', '~> 0.40'

What did you expect to happen?

I was expecting a Podfile.lock to appear, so that I could be sure that the version installed on other checkouts of the repo was the same as my local one.

What happened instead?

There was no Podfile.lock 😢

screenshot of the commands I used

CocoaPods Environment

Click to expand

Stack

   CocoaPods : 1.8.4
        Ruby : ruby 2.6.5p114 (2019-10-01 revision 67812) [x86_64-darwin18]
    RubyGems : 3.0.3
        Host : Mac OS X 10.14.6 (18G103)
       Xcode : 11.0 (11A419c)
         Git : git version 2.20.1
Ruby lib dir : /Users/gio/.rbenv/versions/2.6.5/lib
Repositories : cocoapods - git - https://github.com/CocoaPods/Old-Specs @ 6e256ccc84aad851d401fabb79b2c0f9e09bb875
               master - git - https://github.com/CocoaPods/Specs.git @ f0d66623809afc13fe158f95bcab3b94802496b3
               old-specs - git - git@github.com:CocoaPods/Old-Specs.git @ 6e256ccc84aad851d401fabb79b2c0f9e09bb875
               trunk - CDN - https://cdn.cocoapods.org/

Installation Source

Executable Path: /Users/gio/.rbenv/versions/2.6.5/bin/pod

Plugins

cocoapods-deintegrate : 1.0.4
cocoapods-plugins     : 1.0.0
cocoapods-search      : 1.0.0
cocoapods-stats       : 1.1.0
cocoapods-trunk       : 1.4.1
cocoapods-try         : 1.1.0

Podfile

install! 'cocoapods',
  integrate_targets: false,
  skip_pods_project_generation: true

platform :ios, '13.0'

pod 'SwiftFormat/CLI', '~> 0.40'

Project that demonstrates the issue

👉 https://github.com/mokagio/podfile-lock-not-generated-example


Thank you for your help 😄

@mokagio
Copy link
Author

mokagio commented Oct 25, 2019

Oh ☝️ . Here's the --verbose output

$ bundle exec pod install --verbose
  Preparing

Analyzing dependencies

Resolving dependencies of `Podfile`
  CDN: trunk Relative path: CocoaPods-version.yml exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: all_pods_versions_5_e_d.txt exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.13/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.0/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.1/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.2/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.3/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.4/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.5/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.6/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.7/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.8/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.9/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.10/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.11/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.12/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update
  CDN: trunk Relative path: Specs/5/e/d/SwiftFormat/0.40.13/SwiftFormat.podspec.json exists! Returning local because checking is only perfomed in repo update

Comparing resolved specification to the sandbox manifest
  A SwiftFormat

Downloading dependencies

-> Installing SwiftFormat (0.40.13)
  > Copying SwiftFormat from `/Users/gio/Library/Caches/CocoaPods/Pods/Release/SwiftFormat/0.40.13-d548b` to `Pods/SwiftFormat`
  - Running pre install hooks

Skipping Pods Project Creation

Skipping User Project Integration
  - Running post install hooks
    - cocoapods-stats from `/Users/gio/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/cocoapods-stats-1.1.0/lib/cocoapods_plugin.rb`
      CDN: trunk Relative path: CocoaPods-version.yml exists! Returning local because checking is only perfomed in repo update

-> Pod installation complete! There is 1 dependency from the Podfile and 1 total pod installed.

[!] The abstract target Pods is not inherited by a concrete target, so the following dependencies won't make it into any targets in your project:
    - SwiftFormat/CLI (~> 0.40)

@dnkoutso
Copy link
Contributor

This is intentional I think due to integrate_targets being disabled and skip_pods_project_generation being enabled.

@dnkoutso
Copy link
Contributor

I suppose we could change it to generate the lockfile because the projects or integration is not needed for that to happen. What is your use case here?

I suspect some folks might not want the opposite if we change it..........

@dnkoutso dnkoutso added s1:awaiting input Waiting for input from the original author and removed s1:awaiting input Waiting for input from the original author labels Oct 25, 2019
@dnkoutso
Copy link
Contributor

Talked to the team internally, we all agree that we should generate the Podfile.lock even when those options are off.

Marking it as a thing to do in 1.9.x

@dnkoutso dnkoutso added this to the 1.9.0 milestone Oct 25, 2019
@dnkoutso dnkoutso added d1:easy An easy ticket that is a good start for first-time contributors t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it labels Oct 25, 2019
@mokagio
Copy link
Author

mokagio commented Oct 26, 2019

@dnkoutso and team. You 👏 are 👏 amazing 👏 ! ❤️

Happy to help with the devving and/or testing if you need.

@dnkoutso dnkoutso added t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome! and removed t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it labels Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d1:easy An easy ticket that is a good start for first-time contributors t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants