Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect --configuration option when analyzing via pod lib lint --analyze #10477

Merged
merged 1 commit into from Mar 16, 2021
Merged

Respect --configuration option when analyzing via pod lib lint --analyze #10477

merged 1 commit into from Mar 16, 2021

Conversation

jmagman
Copy link
Contributor

@jmagman jmagman commented Mar 2, 2021 •
edited

#9760 introduced the --configuration flag and used it for xcodebuild build. Also adopt for xcodebuild analyze for pod lib lint --analyze and pod spec lint --analyze

Fixes #10476

@jmagman jmagman force-pushed the analyze-config branch 2 times, most recently from c13b9f0 to 485d583 Compare March 2, 2021 02:54
@jmagman jmagman marked this pull request as ready for review March 2, 2021 03:00
@jmagman
Copy link
Contributor Author

jmagman commented Mar 2, 2021 

spec/unit/validator_spec.rb:5:3: C: Block has too many lines. [1533/1476]
  describe Validator do ...
  ^^^^^^^^^^^^^^^^^^^^^

This PR pushed the validator_spec file over the "too many lines" lint. How would you like me to split it up?

@jmagman jmagman mentioned this pull request Mar 2, 2021
Merged
@igor-makarov
Copy link
Contributor

Hi @jmagman! This looks exactly like #10238 (comment) - the decision is to disable this rule for specs.

paulb777
paulb777 approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@igor-makarov igor-makarov mentioned this pull request Mar 2, 2021
Merged
@igor-makarov
Copy link
Contributor

@segiddins #10483

@igor-makarov
Copy link
Contributor

@jmagman could you please rebase? This will unblock the linter error.

@jmagman
Copy link
Contributor Author

jmagman commented Mar 2, 2021

@jmagman could you please rebase? This will unblock the linter error.

@igor-makarov Done, thanks for #10483!

@jmagman jmagman mentioned this pull request Mar 3, 2021
Merged
@jmagman
Copy link
Contributor Author

jmagman commented Mar 16, 2021

@paulb777 is this waiting on anything else to be merged? No rush, just want to make sure it's not blocked on me.

@segiddins segiddins merged commit 123f2d0 into CocoaPods:master Mar 16, 2021
@jmagman jmagman deleted the analyze-config branch March 16, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@segiddins segiddins segiddins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"pod lib lint --analyze" ignores --configuration option
4 participants
@jmagman @igor-makarov @paulb777 @segiddins