[1-11-stable] cdn_url? check shouldn't crash operations. Catch YAML.load failure #11221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
approved these changes
Feb 25, 2022
|
@KostyaSha Could you add a Changelog entry please? |
|
@KostyaSha maybe want to add a changelog entry? |
|
Oops sorry I did not see @igor-makarov same comment! sorry |
|
one sec |
KostyaSha
force-pushed
the
1-11-fix
branch
2 times, most recently
from
b315f25
to
94a389d
Compare
Some services (i.e. gitlab) on https://url/repo.git/CocoaPods-version.yml will redirect to login page with http status 200. Such response body will not be a valid YAML and throw exception. HTML in a test case was YAML compatible, now it's a real garbage.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some services (i.e. gitlab) on https://url/repo.git/CocoaPods-version.yml will redirect to login page with http status 200.
Such response body will not be a valid YAML and throw exception.
HTML in a test case was YAML compatible, now it's a real garbage.