Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AppHost infoplist integration #11692 #11820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix AppHost infoplist integration #11692 #11820

wants to merge 1 commit into from

Conversation

blastmann
Copy link

@blastmann blastmann commented Mar 16, 2023 •
edited

Try to fix this issue by adding additional_entries into AppHostInstaller installation process.

Add another test case to check the plist result.

@blastmann

This comment was marked as resolved.

Sign in to view
@blastmann blastmann changed the title fix: fix AppHost infoplist integration #11692 Fix AppHost infoplist integration #11692 Apr 10, 2023
@blastmann
Copy link
Author

Hi, I just fixed the lint issues that were causing the workflows to fail. Please retry them again and let me know if there are any errors or warnings.

@blastmann blastmann force-pushed the master branch 4 times, most recently from 89bcf34 to 03a0320 Compare April 11, 2023 02:31
@blastmann
Copy link
Author

1 Warning
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
Here's an example of your CHANGELOG entry:

* Fix AppHost infoplist integration #11692  
  [blastmann](https://github.com/blastmann)
  [#issue_number](https://github.com/CocoaPods/CocoaPods/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

Done.

@blastmann
Copy link
Author

blastmann commented Apr 13, 2023 •
edited

Conflicts of CHANGELOG.md have been resolved.

@blastmann
Copy link
Author

I hope it can be merged as soon as possible. If there is anything I should correct, please let me know.

paulb777
paulb777 reviewed Apr 17, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@dnkoutso
Copy link
Contributor

1.12.1 was released, need to update your changelog entry to be in the correct spot! sorry for this.

@blastmann blastmann force-pushed the master branch 2 times, most recently from 1612423 to 6997966 Compare April 19, 2023 09:54
@blastmann
Copy link
Author

1.12.1 was released, need to update your changelog entry to be in the correct spot! sorry for this.

OK, I move the changelog entry to master section.

@blastmann blastmann requested a review from paulb777 May 4, 2023 09:35
@blastmann
Copy link
Author

1.12.1 was released, need to update your changelog entry to be in the correct spot! sorry for this.

Ready to merge bro. :)

@blastmann
Copy link
Author

@dnkoutso check please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 Awaiting requested review from paulb777

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blastmann @dnkoutso @paulb777