Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requiring base active_support before definitions #12082

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Requiring base active_support before definitions #12082

merged 2 commits into from
Oct 5, 2023
+4 −1

Conversation

MCanhisares
Copy link
Contributor

As per the official active_support documentation, we should import the base library before the specific definitions on files.

This fixes #12081

@MCanhisares
Copy link
Contributor Author

MCanhisares commented Oct 5, 2023 •
edited
Loading

Failing lint fixed in #12083
Let me know if you want the two changes on the same branch

@amorde amorde force-pushed the fix/active_support_require branch 2 times, most recently from 49a81ea to 06b9117 Compare October 5, 2023 22:45
@amorde amorde merged commit 2164788 into CocoaPods:master Oct 5, 2023
5 checks passed
@ghiculescu ghiculescu mentioned this pull request Oct 6, 2023
Closed
@itinance
Copy link

itinance commented Oct 6, 2023

When is a release planned with this fix?

@rarkins rarkins mentioned this pull request Oct 6, 2023
Closed
@maxlapides maxlapides mentioned this pull request Oct 9, 2023
Closed
@nikolaykasyanov nikolaykasyanov mentioned this pull request Oct 10, 2023
Closed
1 task
@eluzgin
Copy link

eluzgin commented Oct 10, 2023

We need release of this fix ASAP! Lot's of broken projects are waiting.

@eluzgin
Copy link

eluzgin commented Oct 10, 2023

@amorde Please do a release. This is blocker issue for many projects!

@Schwad Schwad mentioned this pull request Oct 11, 2023
Open
@nikolaykasyanov nikolaykasyanov mentioned this pull request Oct 12, 2023
Merged
@Zandor300
Copy link

@itinance @eluzgin

Expect a new release in months time. visionOS support to be released in a new version took just under 3 months.

See commit merged to master on June 29th: 7234edf

And v1.13.0 being released on September 22nd: https://github.com/CocoaPods/CocoaPods/releases/tag/1.13.0

Such an important tool for the Apple developer community being neglected will only cause even more devs to move to SPM.

@zorgiepoo zorgiepoo mentioned this pull request Oct 16, 2023
Closed
@crherman7 crherman7 mentioned this pull request Oct 16, 2023
Closed
@rafaelfranca rafaelfranca mentioned this pull request Oct 20, 2023
Closed
@isaac-weisberg
Copy link

Why isn't there a minor release if this critical fix is already merged?!

@Zandor300
Copy link

@dnkoutso Could you please do a release of master?

@AliSoftware
Copy link
Contributor

This fix has now been released as part of 1.14.0 🎉

@alejandroperea alejandroperea mentioned this pull request Dec 6, 2023
Merged
7 tasks
@ameedsayeh ameedsayeh mentioned this pull request Feb 18, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorde amorde amorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incompatibility with activesupport 7.1.0
7 participants
@MCanhisares @itinance @eluzgin @Zandor300 @isaac-weisberg @AliSoftware @amorde