Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation fail when Publishing iOS pods to private specs repo using Xcode 14.3. or upper #12151

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix validation fail when Publishing iOS pods to private specs repo using Xcode 14.3. or upper #12151

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aba8662
Update analyzer.rb
tkgka Nov 16, 2023
0ad0eda
Update analyzer.rb
tkgka Nov 17, 2023
19e1d72
Merge branch 'master' into patch-1
tkgka Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cocoapods/installer/analyzer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,7 +865,7 @@ def determine_platform(specs, target_definitions, build_type)
Version.new(library_spec.deployment_target(platform_name) || default)
end.max
if platform_name == :ios && build_type.framework?
minimum = Version.new('8.0')
minimum = Version.new('11.0')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably the wrong place in the code for this change, since this is specifying 8.0 is when Apple introduced framework support for iOS. The change should also impact tvOS, macOS, and tvOS

Copy link
Author

@tkgka tkgka Nov 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulb777
does it possible to impact other OS(watchOS, macOS and tvOS)?
change only run when the platform_name is iosbecause of the top line code
if platform_name == :ios && build_type.framework?

Copy link
Author

@tkgka tkgka Nov 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I think it right place to change because I change every singe code that determine the version 8.0 to 12.0 one by one and only place that can help was the lib/cocoapods/installer/analyzer.rb

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macos and tvos have the same issue as ios and should have a similar fix.

Copy link
Author

@tkgka tkgka Nov 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulb777
ah now I see, but currently this fix is for iOS, so what about fix other platform's issue on the other commit? (I cannot find the source for other platform on this file)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulb777 can you check whether it can merge or not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described, this is the wrong place for managing minimum version. This code is for testing if frameworks are supported or not on iOS.

deployment_target = [deployment_target, minimum].max
end
Platform.new(platform_name, deployment_target)
Expand Down