[PodTarget] Ensure the deployment target is high enough for frameworks

[segiddins]

closes #4552.

• Documentation
• CHANGELOG (fixing a bug introduced since 0.39.0)
• Specs
• Rebuild integration specs

This is really really gross, but more correct. Would appreciate suggestions on how to refactor it.

[segiddins]

@CocoaPods/core thoughts on this one, please?

[neonichu]

@segiddins I'm not quite sure what this even does :) Could you outline the problem a bit?

[segiddins]

Makes sure the iOS deployment target is not less than 8.0 when using frameworks.

[neonichu]

I thought that we would already do that, that's what confused me, but turns out it is only something we check when validating the deployment target of a Pod.

[manuyavuz]

This documentation probably wrongly copied.

[segiddins]

I don't understand why the integration specs are failing in the way they are? Think I have a fix for that

[segiddins]

@CocoaPods/core please review. I will update the integration specs and merge once i get a thumbs-up

[manuyavuz]

@segiddins Is the change in integration specs for install_custom_module_name normal? User project has deployment target of 8.2, previous execution output was including - Installing target 'SocketRocket' iOS 8.2 as expected, but with your changes, it has returned to - Installing target 'SocketRocket' iOS 8.0

I'm not sure this is an expected change.

[segiddins]

Yes, this is exactly the expected change, since the pod's deployment target (as set in the podspec) is 8.0

[manuyavuz]

Could you direct me to the corresponding podspec? I see ios 6.0 here: https://github.com/CocoaPods/Specs/blob/master/Specs/libPusher/1.6.1/libPusher.podspec.json Does it use a different podspec?

[segiddins]

Ah sorry, was thinking about the other spec. No, it uses that podspec, but its integrating as a framework, so the minimum deployment target shouldn't be lower than 8.0

[manuyavuz]

But the thing is it was also having iOS 8.2 before, and downgraded to 8.0. I think I misunderstand the proposed fix here. Previous to your changes, Pods project was getting deployment target from user project, which was causing wrong deployment target setups, and with your change, deployment targets for Pods project and pod targets are solely determined via constraints in podfile or podspecs Therefore, it correctly downgraded to 8.0 because only requirement for the pod was use_frameworks! The 8.2 requirement set by user project should not effect the requirement of Pods project. Am I right?

[segiddins]

it being 8.2 earlier was probably a bug. but yes, you're correct that user project deployment targets should no longer effect the deployment targets for podtargets

[manuyavuz]

So we could directly observed that your change really ensures the deployment target requirement for pod targets :)

Thumbs up from me!

[segiddins]