Fix resource bundle paths for improved deduplication

[mrackwitz]

While #4146 fixed one problem described in #4872, it brought up another one. The paths in the CopyResourcesScript passed to the install_resource function for resource bundles are wrong.

[segiddins]

\c @efirestone

[mrackwitz]

This changes the used base path variable from BUILT_PRODUCTS_DIR to CONFIGURATION_BUILD_DIR, while the documentation states:

Run Script build phases can use the value of this build setting as a convenient way to refer to the product files built by one or more targets even when these files are scattered throughout a directory hierarchy (for example, when DEPLOYMENT_LOCATION is set to YES.

But according to the documented value of the setting BUILT_PRODUCTS_DIR, it takes only a different value when RETAIN_RAW_BINARIES is also set to YES, what doesn't seem to have much practical relevance.

[segiddins]

RuboCop failures: https://travis-ci.org/CocoaPods/CocoaPods/jobs/111974486#L2693-L2703

[efirestone]

LGTM

[arifken]

Thanks for fixing this! i've been running into this issue as well. looking forward to it in the next beta. 👍

[gcox]

Not sure this is totally fixed. It did fix the path issue I was having with the 1PasswordExtension but it caused a new issue for the google-cast-sdk pod.

The path passed to install_resource for this pod is "$CONFIGURATION_BUILD_DIR/google-cast-sdk/CastFrameworkAssets.bundle" but the actual path is "$CONFIGURATION_BUILD_DIR/CastFrameworkAssets.bundle". Not sure if this is a bug in the generation of the path or placement of CastFrameworkAssets.bundle.

[segiddins]

@gcox please open a new issue with a project that reproduces the issue