Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Allow skipping import validation #5677

Closed
wants to merge 1 commit into from

Conversation

segiddins
Copy link
Member

  • Specs
  • CHANGELOG
  • Update cocoapods-trunk

@CocoaPodsBarista
Copy link

CocoaPodsBarista commented Jul 26, 2016

1 Error
🚫 Please include a CHANGELOG entry to credit yourself! You can find it at CHANGELOG.md.

Here's an example of your CHANGELOG entry:

* [Validator] Allow skipping import validation 
  [segiddins](https://github.com/segiddins)
  [#issue_number](https://github.com/CocoaPods/CocoaPods/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 danger

@@ -424,7 +428,7 @@ def write_app_import_source_file(pod_target)
f << "@import Foundation;\n"
f << "@import UIKit;\n" if consumer.platform_name == :ios || consumer.platform_name == :tvos
f << "@import Cocoa;\n" if consumer.platform_name == :osx
f << "#{import_statement}int main() {}\n"
f << import_statement
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this change

@igagis
Copy link

igagis commented Aug 4, 2016

Hi,
any progress on this?

@segiddins
Copy link
Member Author

@igagis it's still awaiting someone writing tests

@segiddins
Copy link
Member Author

Closing in favor of #6420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants