Exclude test resource and framework paths from aggregate targets #7000
Conversation
dnkoutso
force-pushed
the
test_resources_not_on_aggregates
branch
3 times, most recently
from
253c295
to
7a5bd48
Compare
| @@ -200,56 +200,59 @@ def supported_test_types | |||
| # @return [Array<Hash{Symbol => [String]}>] The vendored and non vendored framework paths | |||
| # this target depends upon. | |||
| # | |||
| def framework_paths | |||
| @framework_paths ||= begin | |||
There was a problem hiding this comment.
removed the @framework_paths ||= begin this is why the diff looks weird.
There was a problem hiding this comment.
Easier to review with https://github.com/CocoaPods/CocoaPods/pull/7000/files?w=1
There was a problem hiding this comment.
What's the purpose of removing the caching? This is kinda expensive
There was a problem hiding this comment.
So now we are parameterized whether we return paths including the ones from tests or not.
I can actually cache it where the key includes the boolean if you'd like. WDYT?
There was a problem hiding this comment.
Cache is now added back and it depends on the parameter.
dnkoutso
force-pushed
the
test_resources_not_on_aggregates
branch
from
7a5bd48
to
79daf74
Compare
lib/cocoapods/target/pod_target.rb
Outdated
| :input_path => build_product_path('${BUILT_PRODUCTS_DIR}'), | ||
| :output_path => "${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/#{product_name}" } | ||
| def framework_paths(include_test_framework_paths = true) | ||
| accessors = file_accessors.flat_map |
There was a problem hiding this comment.
What's the flat_map here with no block for?
dnkoutso
force-pushed
the
test_resources_not_on_aggregates
branch
3 times, most recently
from
3269c95
to
710dcfe
Compare
dnkoutso
changed the title
dnkoutso
force-pushed
the
test_resources_not_on_aggregates
branch
from
710dcfe
to
060048f
Compare
dnkoutso
changed the title
dnkoutso
force-pushed
the
test_resources_not_on_aggregates
branch
from
060048f
to
7408faf
Compare
dnkoutso
changed the title
dnkoutso
force-pushed
the
test_resources_not_on_aggregates
branch
from
7408faf
to
4a6dad4
Compare
|
Just amended the commit message to be more accurate. No code changes on the last push. |
dnkoutso
force-pushed
the
test_resources_not_on_aggregates
branch
from
4a6dad4
to
000ca1f
Compare
|
All green! |
No description provided.