Do not symlink headers that belong to test specs #7762
Conversation
dnkoutso
commented
May 21, 2018
•
dnkoutso
commented
- make sure there is an integration spec for test specs, there might be one already but I want to double check
|
Talked offline, need to remove from private folder too and rely on header maps instead to make the "magic" work. /cc @paulb777 if you have any suggestions about this. |
|
relying on header maps slightly scares me...but its a high cost to move the test headers under different folders etc. |
dnkoutso
force-pushed
the
no_symlink_public_test_headers
branch
from
eea4b5e
to
053c916
Compare
dnkoutso
changed the title
| coconut_test_spec = coconut_spec.test_specs.first | ||
| coconut_pod_target = fixture_pod_target_with_specs([coconut_spec, coconut_test_spec], false) | ||
| public_headers_root = config.sandbox.public_headers.root | ||
| private_headers_root = @pod_target.build_headers.root |
There was a problem hiding this comment.
whoops this should coconut_pod_target still worked though cause its the same path.
dnkoutso
force-pushed
the
no_symlink_public_test_headers
branch
2 times, most recently
from
82c06c3
to
12e13ff
Compare
dnkoutso
force-pushed
the
no_symlink_public_test_headers
branch
from
12e13ff
to
ca6e928
Compare
|
p.s this change only affects static libs and test specs. |
|
There is an integration spec but does not have headers...will update that first before merging this. |
|
Actually this is OK to land. Test xcconfigs still receive the header search paths for their library anyway. This continues to work as expected and removes the symlinks from test specs. Makes it even better because other libraries cannot accidentally import these headers! |
