Re-implement `dSYM` copying and stripping to avoid duplicate outputs. #9547

dnkoutso · 2020-02-20T00:42:49Z

dSYMs should have never been treated as objects to "embed" like .frameworks all they need is copying and stripping. This PR move those steps into a single target and avoids multiple targets being built producing the same "output" in which Xcode 11 errors out.

closes #9185

integration specs: CocoaPods/cocoapods-integration-specs#269

amorde

looking great! nice work

lib/cocoapods/installer/xcode/pods_project_generator/pod_target_integrator.rb

dnkoutso · 2020-02-20T23:41:10Z

lib/cocoapods/installer/user_project_integrator/target_integrator.rb

@@ -263,7 +267,9 @@ def create_or_update_shell_script_build_phase(native_target, script_phase_name,
          def create_or_update_user_script_phases(script_phases, native_target)
            script_phase_names = script_phases.map { |k| k[:name] }
            # Delete script phases no longer present in the target.
-            native_target_script_phases = native_target.shell_script_build_phases.select { |bp| !bp.name.nil? && bp.name.start_with?(USER_BUILD_PHASE_PREFIX) }
+            native_target_script_phases = native_target.shell_script_build_phases.select do |bp|


just formatting as line was too long. no changes.

lib/cocoapods/installer/xcode/pods_project_generator/pod_target_integrator.rb

dnkoutso · 2020-02-20T23:46:34Z

lib/cocoapods/generator/prepare_artifacts_script.rb

@@ -59,113 +59,103 @@ def generate
      #
      def script
        script = <<-SH.strip_heredoc
-          #!/bin/sh


just updated indentation. I think because I added string interpolation to the mix it broke indentation. Either way no changes here except using the script constants instead.

lib/cocoapods/installer/user_project_integrator/target_integrator.rb

lib/cocoapods/installer/xcode/pods_project_generator.rb

lib/cocoapods/installer/xcode/pods_project_generator/pod_target_integrator.rb

nikolaykasyanov

👏

lib/cocoapods/installer/xcode/pods_project_generator/pod_target_integrator.rb

nikolaykasyanov · 2020-02-21T08:35:30Z

I'm getting a build error using New Build System (Xcode ~~11.3.1~~11.4 beta 2) on this branch:

Showing All Messages
Build system information
error: Cycle in dependencies between targets 'A-Unit-Tests' and 'A'; building could produce unreliable results.
Cycle path: A-Unit-Tests → A → A-Unit-Tests
Cycle details:
→ That command depends on command in Target 'A-Unit-Tests': script phase “[CP] Embed Pods Frameworks”
→ Target 'A-Unit-Tests' has target dependency on Target 'A'
→ Target 'A' has target dependency on Target 'B'
○ That command depends on command in Target 'B': script phase “[CP] Copy dSYMs”

Target name explanation.

UPD there's also a warning from the build system, not sure if related:

Showing All Messages
missing creator for mutated node: ('/Users/user/Library/Developer/Xcode/DerivedData/project-bfjsebfzwmezwxetcmlmiduwobqw/Build/Products/Debug-iphonesimulator/B/B.framework.dSYM')

nikolaykasyanov · 2020-02-21T08:58:11Z

Looks like [CP] Copy dSYMs output file list refernce is incorrect (equal to the input list):
${PODS_ROOT}/Target Support Files/B/B-strip-dsym-input-files.xcfilelist

lib/cocoapods/installer/xcode/pods_project_generator/pod_target_integrator.rb

nikolaykasyanov

Working great 🎉

dnkoutso · 2020-02-21T20:58:03Z

Re did it with a file instead but same functionality. Merging.

migonin · 2020-03-04T13:18:10Z

@dnkoutso did it fix #7155 also?

amorde · 2020-03-04T22:08:38Z

@migonin no, this PR only changes the implementation details of how .dSYM symbols get included in archives.

Please keep comments about issues on that issue itself, it's difficult to jump around issues & PRs to follow conversation when its not in one place.

umar1136 · 2022-01-27T23:14:14Z

expect

dnkoutso added this to the 1.10.0 milestone Feb 20, 2020

dnkoutso mentioned this pull request Feb 20, 2020

"Multiple commands produce" error when building unit test target without a host #9185

Closed

1 task

amorde reviewed Feb 20, 2020

View reviewed changes

lib/cocoapods/installer/xcode/pods_project_generator/pod_target_integrator.rb Outdated Show resolved Hide resolved

dnkoutso force-pushed the dsym_revamp branch 6 times, most recently from ad190fa to 6e2b0c2 Compare February 20, 2020 23:24

dnkoutso changed the title ~~WIP - Revamp dSYM integration~~ Revamp dSYM integration Feb 20, 2020

dnkoutso force-pushed the dsym_revamp branch 2 times, most recently from 028e1bb to b10dabb Compare February 20, 2020 23:39

dnkoutso mentioned this pull request Feb 20, 2020

Update integration specs for revamped dSYM integration. CocoaPods/cocoapods-integration-specs#269

Merged

dnkoutso commented Feb 20, 2020

View reviewed changes

lib/cocoapods/installer/xcode/pods_project_generator/pod_target_integrator.rb Outdated Show resolved Hide resolved

dnkoutso commented Feb 20, 2020

View reviewed changes

dnkoutso force-pushed the dsym_revamp branch from b10dabb to 65c6974 Compare February 20, 2020 23:51

amorde reviewed Feb 20, 2020

View reviewed changes

lib/cocoapods/installer/user_project_integrator/target_integrator.rb Outdated Show resolved Hide resolved

dnkoutso force-pushed the dsym_revamp branch 3 times, most recently from b983379 to db2e3d7 Compare February 21, 2020 00:10

amorde reviewed Feb 21, 2020

View reviewed changes

dnkoutso force-pushed the dsym_revamp branch from db2e3d7 to 6bc5b2f Compare February 21, 2020 01:53

nikolaykasyanov reviewed Feb 21, 2020

View reviewed changes

lib/cocoapods/installer/xcode/pods_project_generator/pod_target_integrator.rb Show resolved Hide resolved

nikolaykasyanov suggested changes Feb 21, 2020

View reviewed changes

lib/cocoapods/installer/xcode/pods_project_generator/pod_target_integrator.rb Outdated Show resolved Hide resolved

dnkoutso force-pushed the dsym_revamp branch 3 times, most recently from 9cf0b0f to f339988 Compare February 21, 2020 15:59

dnkoutso force-pushed the dsym_revamp branch 5 times, most recently from 9f55cde to babcc11 Compare February 21, 2020 17:50

dnkoutso changed the title ~~Revamp dSYM integration~~ Re-implement dSYM copying and stripping to avoid duplicate outputs. Feb 21, 2020

nikolaykasyanov approved these changes Feb 21, 2020

View reviewed changes

amorde approved these changes Feb 21, 2020

View reviewed changes

dnkoutso force-pushed the dsym_revamp branch 3 times, most recently from 9662858 to 702cfe6 Compare February 21, 2020 20:32

Re-implement dSYM copying and stripping to avoid duplicate outputs.

c805dde

dnkoutso force-pushed the dsym_revamp branch from 702cfe6 to c805dde Compare February 21, 2020 20:41

dnkoutso merged commit 9817297 into CocoaPods:master Feb 21, 2020

dnkoutso deleted the dsym_revamp branch February 21, 2020 21:01

dnkoutso mentioned this pull request Feb 22, 2020

Issue with vendored ".framework.dSYM" files #9419

Closed

1 task

amorde mentioned this pull request Apr 16, 2020

XCFramework Rework #9720

Merged

mplorentz mentioned this pull request Apr 20, 2020

Fix vendored .bcsymbolmap on new build system #9734

Merged

christophermark mentioned this pull request Jun 30, 2020

iOS build error after upgrading from 7.0.9 to 8.0.0 (on New Build System) rnmapbox/maps#932

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-implement `dSYM` copying and stripping to avoid duplicate outputs. #9547

Re-implement `dSYM` copying and stripping to avoid duplicate outputs. #9547

dnkoutso commented Feb 20, 2020 •

edited

amorde left a comment

dnkoutso Feb 20, 2020

dnkoutso Feb 20, 2020

nikolaykasyanov left a comment

nikolaykasyanov commented Feb 21, 2020 •

edited

nikolaykasyanov commented Feb 21, 2020

nikolaykasyanov left a comment

dnkoutso commented Feb 21, 2020

migonin commented Mar 4, 2020

amorde commented Mar 4, 2020

umar1136 commented Jan 27, 2022

Re-implement dSYM copying and stripping to avoid duplicate outputs. #9547

Re-implement dSYM copying and stripping to avoid duplicate outputs. #9547

Conversation

dnkoutso commented Feb 20, 2020 • edited

amorde left a comment

Choose a reason for hiding this comment

dnkoutso Feb 20, 2020

Choose a reason for hiding this comment

dnkoutso Feb 20, 2020

Choose a reason for hiding this comment

nikolaykasyanov left a comment

Choose a reason for hiding this comment

nikolaykasyanov commented Feb 21, 2020 • edited

nikolaykasyanov commented Feb 21, 2020

nikolaykasyanov left a comment

Choose a reason for hiding this comment

dnkoutso commented Feb 21, 2020

migonin commented Mar 4, 2020

amorde commented Mar 4, 2020

umar1136 commented Jan 27, 2022

Re-implement `dSYM` copying and stripping to avoid duplicate outputs. #9547

Re-implement `dSYM` copying and stripping to avoid duplicate outputs. #9547

dnkoutso commented Feb 20, 2020 •

edited

nikolaykasyanov commented Feb 21, 2020 •

edited