Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linter] check wether social_media_url is set to the example value #67

Closed
fabiopelosin opened this issue Mar 27, 2014 · 3 comments · Fixed by #85
Closed

[Linter] check wether social_media_url is set to the example value #67

fabiopelosin opened this issue Mar 27, 2014 · 3 comments · Fixed by #85

Comments

@fabiopelosin
Copy link
Member

From CocoaPods/CocoaPods#1927

@dlackty
Copy link
Contributor

dlackty commented Mar 29, 2014

Since the podspec template was generated using user's name:

# s.social_media_url   = "http://twitter.com/#{data[:author_name]}"

There's no such "default" value, right?

@orta
Copy link
Member

orta commented Mar 29, 2014

In this case it's coming from https://github.com/CocoaPods/pod-template/blob/master/NAME.podspec

@fabiopelosin fabiopelosin changed the title Add a linter that your social_media_url isn't default [Linter] check wether social_media_url is set to the example value Mar 31, 2014
@fabiopelosin
Copy link
Member Author

Now the template has been fixed and the default value is:

https://twitter.com/EXAMPLE

This can be easily implemented by duplicating this logic of the linter and the relative specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants