removed inhibit_all_warnings? and merged with inhibit_warnings_for_pod? #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # | ||
| def inhibits_warnings_for_pod?(pod_name) | ||
| return true if inhibit_warnings_hash['all'] || (parent.inhibits_warnings_for_pod?(name) unless root?) | ||
|
|
||
| inhibit_warnings_hash['for_pods'] ||= [] | ||
| inhibit_warnings_hash['for_pods'].include? pod_name | ||
| end |
There was a problem hiding this comment.
With this implementation the target definition will inherit the inhibit_all_warnings! DSL directive but not will not inherit it when the users specify it per pod. I don't have any strong opinion about the inheritance but I think that they should be consistent.
There was a problem hiding this comment.
I'd appreciate if you could paste a real world example, it would make it a bit more clear to me
There was a problem hiding this comment.
Example A
target :ZipApp do
inhibit_all_warnings!
pod 'SSZipArchive'
target :test do
end
endThe test target inherits SSZipArchive and will inhibit the warnings.
Example B
target :ZipApp do
pod 'SSZipArchive', :inhibit_warnings => true
target :test do
end
endThe test target inherits SSZipArchive and will not inhibit the warnings.
|
Other than the comment point this pull looks good. |
fabiopelosin
added a commit
that referenced
this pull request
Apr 8, 2013
removed inhibit_all_warnings? and merged with inhibit_warnings_for_pod?
Ashton-W
pushed a commit
to Ashton-W/Core
that referenced
this pull request
Nov 2, 2015
removed inhibit_all_warnings? and merged with inhibit_warnings_for_pod?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably not ready to be merged yet;
First checkpoint from CocoaPods/CocoaPods#942 solved.