Minor typographical fixes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # spec.source = { :git => "git://github.com/AFNetworking/AFNetworking.git", | ||
| # :tag => "v#{spec.version}" } | ||
| # spec.source = { :git => 'git://github.com/AFNetworking/AFNetworking.git', | ||
| # :tag => 'v#{spec.version}' } |
There was a problem hiding this comment.
The interpolation doesn't work with the single quotes.
There was a problem hiding this comment.
Should v#{spec.version} be in double quotes then?
There was a problem hiding this comment.
Yes, otherwise people less familiar with Ruby might get confused by this example.
|
👍 Thanks! |
fabiopelosin
added a commit
that referenced
this pull request
May 22, 2013
Minor typographical fixes
Ashton-W
pushed a commit
to Ashton-W/Core
that referenced
this pull request
Nov 2, 2015
Minor typographical fixes
amorde
added a commit
that referenced
this pull request
Jan 24, 2019
…tation Closes #18 The documentation for this attribute seems pretty substantial, this adds the last item mentioned on that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the CocoaPods website's main specification page, single quotes are used for the source URL and the tag. This pull request aims to make that consistent in the
sourcedocumentation.