Update comments/docs to indicate :skip will skip pch generation #412
Conversation
paulb777
changed the title
| # | ||
| # @example | ||
| # | ||
| # spec.prefix_header_file = 'iphone/include/prefix.pch' | ||
| # spec.prefix_header_file = ':skip' |
There was a problem hiding this comment.
this should probably use a symbol instead of a string? Since :skip could very well be a valid file path
There was a problem hiding this comment.
or spec.prefix_header_file = false ?
There was a problem hiding this comment.
false is good. Made that change. Thanks!
| # | ||
| attribute :prefix_header_file, | ||
| :types => [TrueClass, FalseClass, String], |
There was a problem hiding this comment.
What will setting it to true do?
There was a problem hiding this comment.
I added true for symmetry with false. If it is set, it will behave the same as if the option is not set at all and the default CocoaPods pch file will be generated.
| @@ -25,6 +25,12 @@ def requires_arc | |||
| attributes_hash['requires_arc'] | |||
| end | |||
|
|
|||
| # @return [Bool, String] The prefix_header_file value. | |||
| # | |||
| def prefix_header_file | |||
There was a problem hiding this comment.
this method is specified within root_attribute_accessor but within dsl.rb the declaration of of the attribute itself does not use root_attribute but rather attribute.
Is this the right place to include this method?
There was a problem hiding this comment.
I'm not sure, but I modeled it after the requires_arc implementation which does the same thing.
|
Yea probably a mistake in #393... I can make another PR to clean this up, but i think |
|
Gonna go ahead and merge this. |
|
@paulb777 can you update the cocoapods PR? thank you! |
|
Thanks @dnkoutso! CocoaPods/CocoaPods#7044 is now squashed, rebased and green. |
Replacing #406 based on discussion at CocoaPods/CocoaPods#6815
The corresponding CocoaPods PR is CocoaPods/CocoaPods#7044
This PR does not change any Core functionality.