Add ability to lockfile to retrieve spec repo for pod name #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
change_sources_message
branch
from
633de7d
to
baf0568
Compare
dnkoutso
force-pushed
the
change_sources_message
branch
from
baf0568
to
c80c5cc
Compare
amorde
reviewed
Feb 27, 2018
lib/cocoapods-core/lockfile.rb
Outdated
| # | ||
| def spec_repo(pod_name) | ||
| pods_by_spec_repo.detect { |key, values| break key if values.include?(pod_name) } | ||
| end |
There was a problem hiding this comment.
Should this be cached/memoized in an internal hash? Since CocoaPods/CocoaPods#7464 will use this in a loop, it will end up traversing several times
There was a problem hiding this comment.
I dont think its that much of a problem. The maximum number of times spec_repo method can be called by CocoaPods library is N where N is the number of pods you have and it means that every single one changed its source for this method to be invoked.
I think N ranges from 1-200 here.
Definitely thanks for bringing up as performance can easily degrade on seemingly small changes :)
|
Updated to cache the inverted hash |
segiddins
approved these changes
Mar 5, 2018
amorde
approved these changes
Mar 5, 2018
dnkoutso
force-pushed
the
change_sources_message
branch
from
d9b3aa0
to
f5710a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.