Replace test_only attribute option with spec_types.
#470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
generalize_test_only
branch
2 times, most recently
from
4a78316
to
3feae9d
Compare
|
@segiddins where is the best place to ensure that the value of |
segiddins
reviewed
Nov 15, 2018
| @@ -31,7 +31,7 @@ def initialize(name, options) | |||
|
|
|||
| @multi_platform = options.delete(:multi_platform) { true } | |||
| @root_only = options.delete(:root_only) { false } | |||
| @test_only = options.delete(:test_only) { false } | |||
| @spec_types = options.delete(:spec_types) { [:app] } | |||
There was a problem hiding this comment.
default spec types should be all of them?
should also verify that (@spec_types - Specification::VALID_TYPES).empty?
(that constant might also need to be introduced)
There was a problem hiding this comment.
thanks that was my question above. will change
dnkoutso
force-pushed
the
generalize_test_only
branch
from
3feae9d
to
9ac8d7d
Compare
dnkoutso
force-pushed
the
generalize_test_only
branch
from
9ac8d7d
to
2b80564
Compare
segiddins
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of scheme support and now that we have app specs and test specs.