Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headers option on Http download strategy #557

Merged
merged 2 commits into from
Jul 11, 2019

Conversation

wilmarvh
Copy link
Contributor

@wilmarvh wilmarvh commented Jul 4, 2019

This is a supporting PR for the functionality introduced in CocoaPods/cocoapods-downloader#89.

  • Add an option :headers key for the caller to provide custom headers

@wilmarvh wilmarvh changed the title Add headers option on RemoteFile/Http Add headers option on Http download strategy Jul 4, 2019
@dnkoutso dnkoutso added this to the 1.8 milestone Jul 9, 2019
@dnkoutso
Copy link
Contributor

dnkoutso commented Jul 9, 2019

Please rebase to latest master and add CHANGELOG entry.

@wilmarvh
Copy link
Contributor Author

@dnkoutso Somehow messed the rebase, so reapplied the commits and force pushed to clean it up. Hope it's correct.

CHANGELOG.md Outdated Show resolved Hide resolved
@dnkoutso
Copy link
Contributor

One more rebase to latest master if possible

- Add an option :headers key for the caller to provide custom headers
@wilmarvh
Copy link
Contributor Author

@dnkoutso Done!

@dnkoutso dnkoutso merged commit 1f783ab into CocoaPods:master Jul 11, 2019
@dnkoutso
Copy link
Contributor

released cocoapods-downloader 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants