Added user_agent argument to http methods #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
reviewed
Jul 29, 2019
| require 'rest' | ||
|
|
||
| resp = ::REST.head(url, 'User-Agent' => USER_AGENT) | ||
| user_agent ||= USER_AGENT |
There was a problem hiding this comment.
can also set that as the default?
def self.perform_head_request(url, user_agent = USER_AGENT)
# code
endThere was a problem hiding this comment.
I did at first, but realized this method is private to http.rb, so it becomes easier to pass nil at the call site(s) and then substitute it here (we could also expose the USER_AGENT default value as public, if you'd prefer).
1 task
…a caller, so the social media validator can specify something different (Issue CocoaPods/CocoaPods#9049)
dnkoutso
reviewed
Jul 29, 2019
CHANGELOG.md
Outdated
| @@ -45,6 +45,10 @@ | |||
| [Eric Amorde](https://github.com/amorde) | |||
| [CocoaPods/CocoaPods#8785](https://github.com/CocoaPods/CocoaPods/issues/8785) | |||
|
|
|||
| * Pass a non-browser user agent for social media validation | |||
There was a problem hiding this comment.
nit add two empty spaces at the end of this line for markdown formatting.
dnkoutso
reviewed
Jul 29, 2019
lib/cocoapods-core/http.rb
Outdated
| @@ -8,11 +8,11 @@ module HTTP | |||
| # | |||
| # @return [string] | |||
| # | |||
| def self.get_actual_url(url) | |||
| def self.get_actual_url(url, user_agent=nil) | |||
There was a problem hiding this comment.
nit formatting is off here use bundle exec rubocop -a
dnkoutso
approved these changes
Jul 30, 2019
dnkoutso
pushed a commit
to CocoaPods/CocoaPods
that referenced
this pull request
Jul 30, 2019
* Using change from CocoaPods/Core#571 to address Issue #9049 * Fixed bug, added changelog entry, fixed style violations * Updated non-browser user agent to 'CocoaPods' * Added PR CocoaPods/Core#571 as dependency until it's merged * Updated Gemfile to point to master branch for Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way a caller, like the social media validator, can specify something different (Issue CocoaPods/CocoaPods#9049)