Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :configurations DSL for podspec dependencies. #586

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

segiddins
Copy link
Member

@segiddins segiddins commented Sep 7, 2019

@dnkoutso dnkoutso force-pushed the segiddins/podspec-deps-by-config branch 2 times, most recently from 3a161a8 to 75ebda8 Compare September 25, 2019 23:38
@dnkoutso dnkoutso marked this pull request as ready for review September 25, 2019 23:38
@dnkoutso dnkoutso force-pushed the segiddins/podspec-deps-by-config branch 3 times, most recently from db208e2 to c1bcdb8 Compare September 26, 2019 00:01
@dnkoutso dnkoutso force-pushed the segiddins/podspec-deps-by-config branch 2 times, most recently from d4e0cd0 to b584419 Compare September 26, 2019 00:08
@dnkoutso dnkoutso force-pushed the segiddins/podspec-deps-by-config branch 3 times, most recently from fa3e447 to f8a4681 Compare September 26, 2019 00:16
@dnkoutso dnkoutso self-requested a review September 26, 2019 00:16
@dnkoutso dnkoutso force-pushed the segiddins/podspec-deps-by-config branch 2 times, most recently from 4c2aec2 to aec2d22 Compare September 27, 2019 18:51
@dnkoutso dnkoutso added this to the 1.9 milestone Oct 1, 2019
@dnkoutso dnkoutso force-pushed the segiddins/podspec-deps-by-config branch 2 times, most recently from 1e7cd61 to 5110330 Compare October 1, 2019 19:10
Copy link
Member Author

@segiddins segiddins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
@dnkoutso dnkoutso force-pushed the segiddins/podspec-deps-by-config branch 2 times, most recently from 4b66d48 to 857c6ea Compare October 1, 2019 19:25
lib/cocoapods-core/specification.rb Outdated Show resolved Hide resolved
@dnkoutso dnkoutso force-pushed the segiddins/podspec-deps-by-config branch from 857c6ea to 3060190 Compare October 2, 2019 14:21
@dnkoutso dnkoutso force-pushed the segiddins/podspec-deps-by-config branch from 3060190 to b4baaa4 Compare October 2, 2019 14:22
@dnkoutso dnkoutso changed the title Podspec deps by config Add :configurations DSL for podspec dependencies. Oct 2, 2019
@dnkoutso
Copy link
Contributor

dnkoutso commented Oct 2, 2019

Will merge on green.

@dnkoutso dnkoutso merged commit c66d42b into master Oct 2, 2019
@dnkoutso dnkoutso deleted the segiddins/podspec-deps-by-config branch October 2, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants