Follow up fix to #595 not to delete other hashes during serialization. #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
changed the title
dnkoutso
force-pushed
the
json_follow_up_Fix
branch
from
ccc167c
to
1c41a66
Compare
segiddins
reviewed
Oct 3, 2019
|
The test that was written in #595 still passes. |
|
Verified that CocoaPods integration specs all pass with this change with 0 checksum changes to files. |
but we should still add a new test for the bug this PR is trying to fix |
dnkoutso
force-pushed
the
json_follow_up_Fix
branch
from
1c41a66
to
12c46b5
Compare
dnkoutso
commented
Oct 4, 2019
dnkoutso
changed the title
dnkoutso
force-pushed
the
json_follow_up_Fix
branch
from
12c46b5
to
13e8522
Compare
dnkoutso
commented
Oct 4, 2019
| @@ -80,6 +81,15 @@ module Pod | |||
|
|
|||
| new_json.should.equal json | |||
| end | |||
|
|
|||
| it 'maintains correct order of keys across versions' do | |||
There was a problem hiding this comment.
@segiddins this test fails when I add hash.delete('platforms') either inside or outside the conditional.
segiddins
approved these changes
Oct 4, 2019
|
I still feel like making an entirely new hash will be less error prone for future changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.