Update comments/docs to indicate module_map=false will skip modulemap file generation
#664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…map` file generation
paulb777
approved these changes
Dec 15, 2020
| @@ -1427,6 +1427,10 @@ def dependency=(args) | |||
| # | |||
| # The module map file that should be used when this pod is integrated as | |||
| # a framework. | |||
| # `false` indicates that the default CocoaPods `modulemap` file should not | |||
dnkoutso
reviewed
Dec 18, 2020
| @@ -7,6 +7,9 @@ | |||
| * Allow version `0` to be used. | |||
| [Eloy Durán](https://github.com/alloy) | |||
| [#657](https://github.com/CocoaPods/Core/pull/657) | |||
| * Update comments/docs to indicate `module_map=false` will skip `modulemap` file generation. | |||
There was a problem hiding this comment.
nit you need extra line here.
dnkoutso
reviewed
Dec 18, 2020
| @@ -1427,6 +1427,10 @@ def dependency=(args) | |||
| # | |||
| # The module map file that should be used when this pod is integrated as | |||
| # a framework. | |||
| # `false` indicates that the default CocoaPods `modulemap` file should not | |||
There was a problem hiding this comment.
need extra line from above here.
dnkoutso
reviewed
Dec 18, 2020
| @@ -1427,6 +1427,10 @@ def dependency=(args) | |||
| # | |||
| # The module map file that should be used when this pod is integrated as | |||
| # a framework. | |||
| # `false` indicates that the default CocoaPods `modulemap` file should not | |||
| # be generated. | |||
| # `true` is the default and indicates that the default CocoaPods | |||
dnkoutso
approved these changes
Dec 18, 2020
|
@till0xff approved. We can merge once we fix the line spacing issues which are minor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also CocoaPods/CocoaPods#10207