Add before_headers and after_headers execution position DSL
#686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
commented
Jul 19, 2021
| @@ -1047,7 +1047,7 @@ def dependency=(args) | |||
| SCRIPT_PHASE_OPTIONAL_KEYS = [:shell_path, :input_files, :output_files, :input_file_lists, :output_file_lists, | |||
| :show_env_vars_in_log, :execution_position, :dependency_file].freeze | |||
|
|
|||
| EXECUTION_POSITION_KEYS = [:before_compile, :after_compile, :any].freeze | |||
| EXECUTION_POSITION_KEYS = [:before_compile, :after_compile, :before_headers, :after_headers, :any].freeze | |||
There was a problem hiding this comment.
if these are added and serialized an older version of cocoapods will not be able to parse them, I think that is OK and the author should use s.cocoapods_version dsl to specify >=. 1.11.0. treating it as :any will make consumption of a pod to be broken anyway.
There was a problem hiding this comment.
I wonder if we could expose that in the docs somehow to clarify that if you use those keys you need X version of CocoaPods
1 task
dnkoutso
force-pushed
the
copy_headers_script_phase
branch
from
ffec78a
to
561d89e
Compare
paulb777
approved these changes
Jul 19, 2021
amorde
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CocoaPods/CocoaPods#10770