Update repo regex to better handle ssh URLs. #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
|
@dnkoutso Sorry I didn't respond earlier - I'm on vacation and check my messages sporadically 😂 Anyways it looks like a good fix 👍🏻 |
|
@igor-makarov no worries! want to approve? :D |
igor-makarov
approved these changes
Sep 2, 2021
dnkoutso
force-pushed
the
repo_normalizer_regex_fix
branch
from
a2ce6e3
to
7a2a574
Compare
dnkoutso
force-pushed
the
repo_normalizer_regex_fix
branch
from
7a2a574
to
40dfc2b
Compare
|
ah crap! I should have done 1-11-stable............... |
|
will cherry-pick into it. |
This was referenced Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #702
@igor-makarov how does this look? See https://rubular.com/r/9pjNikg91btZip for testing.