Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PopoverView to 0.0.2 #3672

Closed
wants to merge 1 commit into from
Closed

Conversation

reynhout
Copy link

new version adds compatibility with ARC and non-ARC projects.

@keith
Copy link
Member

keith commented Aug 21, 2013

I'm not going to overwrite the original repo with this new spec. If you would like your features added the cocoapods distributed version please submit them as a PR to the original repo.

@keith keith closed this Aug 21, 2013
@reynhout
Copy link
Author

I didn't add any features or change any code whatsoever, I just pushed the podspec from the existing project at https://github.com/runway20/PopoverView .

Should I submit another pull request, or are you opposed to this action?

@keith
Copy link
Member

keith commented Aug 21, 2013

The source repo in this spec is a fork though, not the original source

@reynhout
Copy link
Author

So do you suggest opening an issue on the original repo, requesting that they push their podspec?

@keith
Copy link
Member

keith commented Aug 21, 2013

We cannot update unversioned specs (specs that point to a commit). If you'd like to add a new version the repository would have to be tagged. If you would like to use a different commit in your own project you can use some flags in your Podfile documented here

@keith keith reopened this Aug 21, 2013
@keith keith closed this Aug 21, 2013
@reynhout
Copy link
Author

the spec i pushed refers to the original repo, and the podspec implies that repo is tagged. I see now that it is not. So they need to fix their tag and push their podspec to you, correct?

@keith
Copy link
Member

keith commented Aug 21, 2013

Yes, the podspec in their repo is actually pointing to that fork as well. But the existing one in the master repo is not. So they would need to add a tag, probably fix that and push the new spec. Like I said if you wanted an updated version you can use those flags.

@reynhout
Copy link
Author

OK, thanks. I skipped cocoapods for this because it's out of date, I just wanted to make it work for others. I'll open an issue on their repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants