[Update] Add "MagicalRecord/Core" and "MagicalRecord/Shorthand" subspecs #7699
Conversation
…ecs. User needed MR_SHORTHAND enabled should use "MagicalRecord/Shorthand" instead. Discussion: CocoaPods@9e7d7aa#commitcomment-5290889
…Also remove additions to prefix header — importing the header this way is not what the MagicalRecord team recommends, and MR_SHORTHAND shouldn't be enabled by default.
| @@ -8,7 +8,8 @@ Pod::Spec.new do |s| | |||
| s.source = { :git => 'https://github.com/magicalpanda/MagicalRecord.git', :tag => "#{s.version}" } | |||
| s.description = 'Handy fetching, threading and data import helpers to make Core Data a little easier to use.' | |||
| s.source_files = 'Source/**/*.{h,m}' | |||
| s.framework = 'CoreData' | |||
| s.framework = 'CoreData' | |||
| s.requires_arc = true | |||
There was a problem hiding this comment.
Did 1.8.3 require ARC? It's been a long time since I looked at that release…
|
@tonyarnold Let me know when this is ready. |
|
1.8.3 was the last release that worked without ARC. @siuying can you remove the ARC line you added to this spec, and then it'll be right to go. |
|
Sorry I missed that, will fix it |
Set require arc to false.
|
@tonyarnold @Keithbsmiley fixed. |
[Update] Add "MagicalRecord/Core" and "MagicalRecord/Shorthand" subspecs
I'll fix this properly in the next point release of MR.
|
Does it matter that the normal define is (Without the 0) via https://github.com/magicalpanda/MagicalRecord/blob/master/Docs/Installation.md |
|
Was there a reason for modifying all the previous spec versions? This change broke our builds. Should you not have created a new spec with version 2.3? |
|
Use |
|
Right we figured it out. Why did you guys switch the behavior of previous versions of specs? Should that have been a new version? |
|
@Keithbsmiley the way that @siuying has defined it is fine — we're doing an |
|
Defining the shorthand constant never should have been the default for these specs. We made the decision to change that. You can use the old style with the |
|
So to be clear, the decision was made to break compatibility for all code, for all versions, that used what someone considered to be the wrong method for defining shorthand. You say it should be the default for the future but you just attempted to change the past as well... I know I have no right to be demanding about the work you guys do, but in my opinion this is bad versioning practice. |
|
@NikoRoberts I've apologised in a bunch of different spots for the impacts this change had on people's projects, and thanks to @siuying there is a simple workaround for people that want to continue using the shorthand method syntax. I'm not sure what other outcome you'd like to see? |
|
@tonyarnold thank you for the apology and workaround but it still surprises me that the change wasn't reverted. I understand wanting to change the behavior for future versions but existing versions that break when running pod install and this just seems like a mistake which is then "resolved" by all the users of shorthand have to change their code. The fact that All automated deployments would break event though the podfile has locked version to me indicates that this commit should be reverted. Am I incorrect in understanding all versions of the podspec were modified? |
|
@NikoRoberts The old version of the project has not been changed. What change is the build setting of the project, specified in the podspec. The setting (MR_SHORTHAND) is not the default setting of the library, and thus it should not the default setting of the podspec. As a side note, if you want all automated deployment of old version still work even if the pod repo change, you really should check in the Pods folder. |
User needed MR_SHORTHAND enabled should use "MagicalRecord/Shorthand" instead.
Discussion: 9e7d7aa#commitcomment-5290889