[Fixtures] Updated CommonBuildSettings with Xcode 8.3 #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benasher44 Can you review this please? |
segiddins
reviewed
Mar 28, 2017
lib/xcodeproj/constants.rb
Outdated
| @@ -337,6 +338,7 @@ module Constants | |||
| 'GCC_WARN_UNINITIALIZED_AUTOS' => 'YES', | |||
| 'GCC_WARN_UNUSED_FUNCTION' => 'YES', | |||
| 'GCC_WARN_UNUSED_VARIABLE' => 'YES', | |||
| 'CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION' => 'YES', | |||
There was a problem hiding this comment.
Please keep the build settings sorted
benasher44
approved these changes
Mar 29, 2017
|
Thanks again @louisdh |
benasher44
added a commit
that referenced
this pull request
Mar 29, 2017
|
@benasher44 Is a new Xcodeproj release on the horizon? (current one is from December). Since CocoaPods uses this as a vital dependency, the updated build settings (such as Whole Module Optimization for Swift) can be of great advantage. |
|
@louisdh I believe we're trying to get this into the 1.2.1 CocoaPods release. These updates I think should be available in the upcoming 1.2.1.rc.1 release specifically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes from Xcode 8.2.1 to 8.3:
CLANG_WARN_DOCUMENTATION_COMMENTS,CLANG_WARN_INFINITE_RECURSIONandCLANG_WARN_SUSPICIOUS_MOVEare now in the base config.CLANG_ANALYZER_NUMBER_OBJECT_CONVERSIONis nowYES_AGGRESSIVEby default for newly created projects.