Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add_build_configuration for PBXAggregateTarget #565

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Fix add_build_configuration for PBXAggregateTarget #565

merged 1 commit into from
Apr 10, 2018

Conversation

dnkoutso
Copy link
Contributor

@dnkoutso dnkoutso commented Apr 10, 2018 •
edited

PBXAggregateTarget does not have a product_type attribute.

@dnkoutso dnkoutso force-pushed the fix_user_configurations_for_pbxaggregates branch from 1c96ae1 to 4ab10e4 Compare April 10, 2018 02:33
@dnkoutso dnkoutso requested a review from segiddins April 10, 2018 02:35
@segiddins
Copy link
Member

A test for this would be 💯

@dnkoutso dnkoutso force-pushed the fix_user_configurations_for_pbxaggregates branch from 4ab10e4 to 795ca2a Compare April 10, 2018 03:15
@dnkoutso
Copy link
Contributor Author

Test added. will merge on green.

@dnkoutso
Copy link
Contributor Author

Also verified the test fails (crashes) without my change.

@dnkoutso dnkoutso merged commit aac57c4 into CocoaPods:master Apr 10, 2018
@dnkoutso dnkoutso deleted the fix_user_configurations_for_pbxaggregates branch April 10, 2018 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segiddins segiddins Awaiting requested review from segiddins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dnkoutso @segiddins