Update default script phase values to match Xcode 10.

[dnkoutso]

Xcode 10 (actually Xcode 9 too) never sets showEnvVarsInLog=1 inside a pbxproj even though the box is checked. For some reason Xcode 9 does not remove showEnvVarsInLog like Xcode 10 does though.

Additionally Xcode 10 has a different default value that is a comment and transcribed into the pbxproj itself under the script phase.

No need for a new test as its already covered.

Here's what Xcode 10 creates by default:

diff --git a/SampleApp2.xcodeproj/project.pbxproj b/SampleApp2.xcodeproj/project.pbxproj
index edb5a6a..48b6f37 100644
--- a/SampleApp2.xcodeproj/project.pbxproj
+++ b/SampleApp2.xcodeproj/project.pbxproj
@@ -593,6 +593,7 @@
                                B7FF42822126755500542509 /* Sources */,
                                B7FF42832126755500542509 /* Frameworks */,
                                B7FF42842126755500542509 /* Resources */,
+                               B7A3A2A621E7FCC60012B057 /* ShellScript */,
                        );
                        buildRules = (
                        );
@@ -839,6 +840,23 @@
                        shellPath = /bin/sh;
                        shellScript = "# Type a script or drag a script file from your workspace to insert its path.\n";
                };
+               B7A3A2A621E7FCC60012B057 /* ShellScript */ = {
+                       isa = PBXShellScriptBuildPhase;
+                       buildActionMask = 2147483647;
+                       files = (
+                       );
+                       inputFileListPaths = (
+                       );
+                       inputPaths = (
+                       );
+                       outputFileListPaths = (
+                       );
+                       outputPaths = (
+                       );
+                       runOnlyForDeploymentPostprocessing = 0;
+                       shellPath = /bin/sh;
+                       shellScript = "# Type a script or drag a script file from your workspace to insert its path.\n";
+               };

[justinseanmartin]

I'm not sure that Xcodeproj should care about imitating this behavior of Xcode. I assume this default exists mostly for Xcode UI discoverability/usability, but isn't terribly helpful for this gem. I don't feel strongly about this though.

[dnkoutso]

Its nuanced in a sense that if xcodeproj creates an empty script phase with defaults then Xcode will change it again therefore making any repo that is tracked by version control to be dirty.

[dnkoutso]

Although yes not many people in reality create empty script phases through Xcodeproj but its OK to fix this here.

[justinseanmartin]

Are you sure that Xcode will take a project with an empty script phase and automatically add this comment to it? If so, that seems like bizarre behavior on their part to add content.

It makes sense for Xcode to remove the show_env_vars_in_log = 1 if the default behavior is to show environment variables when the setting isn't present.

[dnkoutso]

Yes it does at least with Xcode 10. It also adds it as a comment using # and sets the value. Compared to Xcode 9 that just shows the same text without # but does not set it as part of pbxproj. I tested on both and this is why I changed it here for Xcode 10 and going forward.

[justinseanmartin]

Should something change such that setting this to '1' is equivalent to clearing it?

[dnkoutso]

I am not sure we want to add this logic here so much....I am making the PR in CocoaPods to ensure that this does not happen though