Use modern localization identifier 'en' for the development region #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lish" is deprecated in Xcode 10.2
amorde
approved these changes
Apr 13, 2019
|
LGTM but would like 1 more review. I've experienced this in my own projects as well |
segiddins
approved these changes
Apr 15, 2019
|
Thanks @HeEAaD! |
dnkoutso
reviewed
Apr 16, 2019
| @@ -15,6 +15,9 @@ | |||
| * Normalize xcconfig path when generating includes. | |||
| [bclymer](https://github.com/bclymer) | |||
|
|
|||
| * Use modern localization identifier 'en' for the development region. | |||
There was a problem hiding this comment.
change log entry was not rebased to latest master it now appears as if it was in 1.8.2 will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default development_region from "English" to "en" because "English" is deprecated.
Issue
From the Xcode 10.2 release notes:
https://developer.apple.com/documentation/xcode_release_notes/xcode_10_2_release_notes?language=objc#3136790
This leads to deprecation warnings in Xcode 10.2: