Remove build files when underlying file_ref is removed.
#861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byohay
force-pushed
the
feature/file-reference-remove-build-files
branch
from
6269f59
to
7450dc3
Compare
byohay
force-pushed
the
feature/file-reference-remove-build-files
branch
from
7450dc3
to
7253a62
Compare
byohay
changed the title
file_ref is removed.
byohay
force-pushed
the
feature/file-reference-remove-build-files
branch
from
688994f
to
231eb4e
Compare
|
Hi @byohay thanks for this PR! Can you rebase on latest master please and place the CHANGELOG entry in the appropriate spot? |
|
accidental close |
dnkoutso
reviewed
Dec 15, 2021
CHANGELOG.md
Outdated
| @@ -16,6 +16,10 @@ | |||
| [Max Langer](https://github.com/mangerlahn) | |||
| [#853](https://github.com/CocoaPods/Xcodeproj/pull/853) | |||
|
|
|||
| * file reference: Remove build files when underlying file_ref is removed. | |||
There was a problem hiding this comment.
nit: please add two empty spaces at the end of this line for markdown formatting to work properly.
A build file doesn't have any meaning without its underyling file reference, as it can't be built. In this commit, when a file reference is removed, in addition to the previouls file reference removal logic, the build files that refer to the file references are removed as well.
`PBXReferenceProxy` and `PBXGroup` might have build files that refer to them, and as mentioned in the previous commit, they don't have any meaning without it. Therefore everything that can be a `PBXBuildFile`'s `file_ref` removes the build files that refer to it when being removed.
byohay
changed the title
file_ref is removed.file_ref is removed.
byohay
force-pushed
the
feature/file-reference-remove-build-files
branch
from
231eb4e
to
505e696
Compare
|
@dnkoutso done :) |
|
thanks! |
|
@dnkoutso any change to cut a release soon? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A build file doesn't have any meaning without its underlying file
reference, as it can't be built.
In this commit, when a file reference is removed, in addition to the
previous file reference removal logic, the build files that refer to
the file references are removed as well.
Furthermore, the same is done for other types of objects that can be referenced by a build file:
PBXReferenceProxy,PBXGroup.