-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supporting file type from sonatype nexus query urls #101
Conversation
type from url query
Can you please add a test? |
@dnkoutso I'm a novice ruby dev :) |
Yes add one in Run it as |
@dnkoutso it's working ok now. build is passing on 2/4 machines. the other 2 machines has issues with gem installations not related to my fix. |
The failed tests are an issue with RVM with certain Ruby versions on Travis CI VMs. See #97 |
@seanreinhardtapps @dnkoutso is there a way to rerun ci now that #97 is merged? |
@@ -58,6 +58,28 @@ def should_flatten? | |||
|
|||
def type_with_url(url) | |||
case URI.parse(url).path | |||
when /\.zip$/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this get pulled out into a separate function so the case
logic isn't duplicated in type_with_url_query
? maybe type_with_extension
and then call that here and in type_with_url_query
LGTM with 1 minor change |
@amorde updated |
@amorde Hi Eric,
|
@dnkoutso can you please check this, I really need a proxy working asap and this is a blocker. |
sonatype nexus sometimes uses urls with query params.
attempt to fix: #100
tested locally with sonatype nexus, it works