Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration specs #303

Merged
merged 1 commit into from
Oct 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions install_add_pod/after/Pods/Pods.xcodeproj
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ Targets:
Build Settings:
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CLANG_ENABLE_OBJC_WEAK: 'NO'
CODE_SIGN_IDENTITY: iPhone Developer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine to be removed from Pods.xcodeproj. We set it in CocoaPods to whichever targets we need.

CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -71,7 +70,6 @@ Targets:
Build Settings:
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CLANG_ENABLE_OBJC_WEAK: 'NO'
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -100,7 +98,6 @@ Targets:
Build Settings:
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES: 'NO'
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -118,7 +115,6 @@ Targets:
Build Settings:
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES: 'NO'
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -149,7 +145,6 @@ Targets:
Build Settings:
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CLANG_ENABLE_OBJC_WEAK: 'NO'
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -170,7 +165,6 @@ Targets:
Build Settings:
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CLANG_ENABLE_OBJC_WEAK: 'NO'
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -218,6 +212,7 @@ Build Configurations:
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF: 'YES'
CLANG_WARN_OBJC_LITERAL_CONVERSION: 'YES'
CLANG_WARN_OBJC_ROOT_CLASS: YES_ERROR
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER: 'YES'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct. Again we set this to 'NO' for the pod target xcconfig. This is just the setting for the default Pods.xcodeproj.

CLANG_WARN_RANGE_LOOP_ANALYSIS: 'YES'
CLANG_WARN_STRICT_PROTOTYPES: 'YES'
CLANG_WARN_SUSPICIOUS_MOVE: 'YES'
Expand Down Expand Up @@ -278,6 +273,7 @@ Build Configurations:
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF: 'YES'
CLANG_WARN_OBJC_LITERAL_CONVERSION: 'YES'
CLANG_WARN_OBJC_ROOT_CLASS: YES_ERROR
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER: 'YES'
CLANG_WARN_RANGE_LOOP_ANALYSIS: 'YES'
CLANG_WARN_STRICT_PROTOTYPES: 'YES'
CLANG_WARN_SUSPICIOUS_MOVE: 'YES'
Expand Down
10 changes: 2 additions & 8 deletions install_circular_subspec_dependency/after/Pods/Pods.xcodeproj
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ Targets:
Build Configurations:
- Debug:
Build Settings:
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -85,7 +84,6 @@ Targets:
Base Configuration: Pod1.debug.xcconfig
- Release:
Build Settings:
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -116,7 +114,6 @@ Targets:
Build Configurations:
- Debug:
Build Settings:
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -135,7 +132,6 @@ Targets:
Base Configuration: Pod2.debug.xcconfig
- Release:
Build Settings:
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -166,7 +162,6 @@ Targets:
Build Configurations:
- Debug:
Build Settings:
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -185,7 +180,6 @@ Targets:
Base Configuration: Pod3.debug.xcconfig
- Release:
Build Settings:
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -213,7 +207,6 @@ Targets:
- Debug:
Build Settings:
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES: 'NO'
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -230,7 +223,6 @@ Targets:
- Release:
Build Settings:
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES: 'NO'
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -275,6 +267,7 @@ Build Configurations:
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF: 'YES'
CLANG_WARN_OBJC_LITERAL_CONVERSION: 'YES'
CLANG_WARN_OBJC_ROOT_CLASS: YES_ERROR
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER: 'YES'
CLANG_WARN_RANGE_LOOP_ANALYSIS: 'YES'
CLANG_WARN_STRICT_PROTOTYPES: 'YES'
CLANG_WARN_SUSPICIOUS_MOVE: 'YES'
Expand Down Expand Up @@ -335,6 +328,7 @@ Build Configurations:
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF: 'YES'
CLANG_WARN_OBJC_LITERAL_CONVERSION: 'YES'
CLANG_WARN_OBJC_ROOT_CLASS: YES_ERROR
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER: 'YES'
CLANG_WARN_RANGE_LOOP_ANALYSIS: 'YES'
CLANG_WARN_STRICT_PROTOTYPES: 'YES'
CLANG_WARN_SUSPICIOUS_MOVE: 'YES'
Expand Down
12 changes: 4 additions & 8 deletions install_custom_build_configuration/after/Pods/Pods.xcodeproj
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ Targets:
Build Settings:
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES: 'NO'
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -57,7 +56,6 @@ Targets:
Build Settings:
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES: 'NO'
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -76,7 +74,6 @@ Targets:
Build Settings:
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES: 'NO'
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -94,7 +91,6 @@ Targets:
Build Settings:
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES: 'NO'
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -125,7 +121,6 @@ Targets:
Build Settings:
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CLANG_ENABLE_OBJC_WEAK: 'NO'
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -147,7 +142,6 @@ Targets:
Build Settings:
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CLANG_ENABLE_OBJC_WEAK: 'NO'
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -169,7 +163,6 @@ Targets:
Build Settings:
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CLANG_ENABLE_OBJC_WEAK: 'NO'
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -190,7 +183,6 @@ Targets:
Build Settings:
ARCHS: "$(ARCHS_STANDARD_64_BIT)"
CLANG_ENABLE_OBJC_WEAK: 'NO'
CODE_SIGN_IDENTITY: iPhone Developer
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -238,6 +230,7 @@ Build Configurations:
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF: 'YES'
CLANG_WARN_OBJC_LITERAL_CONVERSION: 'YES'
CLANG_WARN_OBJC_ROOT_CLASS: YES_ERROR
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER: 'YES'
CLANG_WARN_RANGE_LOOP_ANALYSIS: 'YES'
CLANG_WARN_STRICT_PROTOTYPES: 'YES'
CLANG_WARN_SUSPICIOUS_MOVE: 'YES'
Expand Down Expand Up @@ -294,6 +287,7 @@ Build Configurations:
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF: 'YES'
CLANG_WARN_OBJC_LITERAL_CONVERSION: 'YES'
CLANG_WARN_OBJC_ROOT_CLASS: YES_ERROR
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER: 'YES'
CLANG_WARN_RANGE_LOOP_ANALYSIS: 'YES'
CLANG_WARN_STRICT_PROTOTYPES: 'YES'
CLANG_WARN_SUSPICIOUS_MOVE: 'YES'
Expand Down Expand Up @@ -350,6 +344,7 @@ Build Configurations:
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF: 'YES'
CLANG_WARN_OBJC_LITERAL_CONVERSION: 'YES'
CLANG_WARN_OBJC_ROOT_CLASS: YES_ERROR
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER: 'YES'
CLANG_WARN_RANGE_LOOP_ANALYSIS: 'YES'
CLANG_WARN_STRICT_PROTOTYPES: 'YES'
CLANG_WARN_SUSPICIOUS_MOVE: 'YES'
Expand Down Expand Up @@ -410,6 +405,7 @@ Build Configurations:
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF: 'YES'
CLANG_WARN_OBJC_LITERAL_CONVERSION: 'YES'
CLANG_WARN_OBJC_ROOT_CLASS: YES_ERROR
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER: 'YES'
CLANG_WARN_RANGE_LOOP_ANALYSIS: 'YES'
CLANG_WARN_STRICT_PROTOTYPES: 'YES'
CLANG_WARN_SUSPICIOUS_MOVE: 'YES'
Expand Down
6 changes: 2 additions & 4 deletions install_custom_module_map/after/Pods/Pods.xcodeproj
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ Targets:
Build Configurations:
- Debug:
Build Settings:
CODE_SIGN_IDENTITY: ''
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -86,7 +85,6 @@ Targets:
Base Configuration: BananaLib.debug.xcconfig
- Release:
Build Settings:
CODE_SIGN_IDENTITY: ''
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -126,7 +124,6 @@ Targets:
- Debug:
Build Settings:
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES: 'NO'
CODE_SIGN_IDENTITY: ''
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -155,7 +152,6 @@ Targets:
- Release:
Build Settings:
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES: 'NO'
CODE_SIGN_IDENTITY: ''
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -212,6 +208,7 @@ Build Configurations:
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF: 'YES'
CLANG_WARN_OBJC_LITERAL_CONVERSION: 'YES'
CLANG_WARN_OBJC_ROOT_CLASS: YES_ERROR
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER: 'YES'
CLANG_WARN_RANGE_LOOP_ANALYSIS: 'YES'
CLANG_WARN_STRICT_PROTOTYPES: 'YES'
CLANG_WARN_SUSPICIOUS_MOVE: 'YES'
Expand Down Expand Up @@ -272,6 +269,7 @@ Build Configurations:
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF: 'YES'
CLANG_WARN_OBJC_LITERAL_CONVERSION: 'YES'
CLANG_WARN_OBJC_ROOT_CLASS: YES_ERROR
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER: 'YES'
CLANG_WARN_RANGE_LOOP_ANALYSIS: 'YES'
CLANG_WARN_STRICT_PROTOTYPES: 'YES'
CLANG_WARN_SUSPICIOUS_MOVE: 'YES'
Expand Down
8 changes: 2 additions & 6 deletions install_custom_module_name/after/Pods/Pods.xcodeproj
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@ Targets:
Build Configurations:
- Debug:
Build Settings:
CODE_SIGN_IDENTITY: ''
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -216,7 +215,6 @@ Targets:
Base Configuration: libPusher.debug.xcconfig
- Release:
Build Settings:
CODE_SIGN_IDENTITY: ''
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -256,7 +254,6 @@ Targets:
- Debug:
Build Settings:
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES: 'NO'
CODE_SIGN_IDENTITY: ''
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -285,7 +282,6 @@ Targets:
- Release:
Build Settings:
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES: 'NO'
CODE_SIGN_IDENTITY: ''
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -335,7 +331,6 @@ Targets:
Build Configurations:
- Debug:
Build Settings:
CODE_SIGN_IDENTITY: ''
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand All @@ -361,7 +356,6 @@ Targets:
Base Configuration: SocketRocket.debug.xcconfig
- Release:
Build Settings:
CODE_SIGN_IDENTITY: ''
CODE_SIGN_IDENTITY[sdk=appletvos*]: ''
CODE_SIGN_IDENTITY[sdk=iphoneos*]: ''
CODE_SIGN_IDENTITY[sdk=watchos*]: ''
Expand Down Expand Up @@ -416,6 +410,7 @@ Build Configurations:
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF: 'YES'
CLANG_WARN_OBJC_LITERAL_CONVERSION: 'YES'
CLANG_WARN_OBJC_ROOT_CLASS: YES_ERROR
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER: 'YES'
CLANG_WARN_RANGE_LOOP_ANALYSIS: 'YES'
CLANG_WARN_STRICT_PROTOTYPES: 'YES'
CLANG_WARN_SUSPICIOUS_MOVE: 'YES'
Expand Down Expand Up @@ -476,6 +471,7 @@ Build Configurations:
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF: 'YES'
CLANG_WARN_OBJC_LITERAL_CONVERSION: 'YES'
CLANG_WARN_OBJC_ROOT_CLASS: YES_ERROR
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER: 'YES'
CLANG_WARN_RANGE_LOOP_ANALYSIS: 'YES'
CLANG_WARN_STRICT_PROTOTYPES: 'YES'
CLANG_WARN_SUSPICIOUS_MOVE: 'YES'
Expand Down