Build with a spec's compile_flags directive.
#73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,6 +90,7 @@ def build_with_mangling(platform) | |||
|
|
|||
| def compile(platform) | |||
| defines = "GCC_PREPROCESSOR_DEFINITIONS='PodsDummy_Pods_#{@spec.name}=PodsDummy_PodPackage_#{@spec.name}'" | |||
| defines += " #{@spec.consumer(platform).compiler_flags.join(' ')}" | |||
There was a problem hiding this comment.
this could just be defines << @spec.consumer(platform).compiler_flags.join(' ')
There was a problem hiding this comment.
Yup, could definitely change += to << if you'd like, but it needs the leading space on that string.
neonichu
added a commit
that referenced
this pull request
Apr 8, 2015
Build with a spec's `compile_flags` directive.
|
LGTM, thanks for the contribution! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes cocoapods-packager use a podspec's
compiler_flag/compiler_flagswhen building the pod for packaging. Two further related changes are made:specs/specification/builder_spec.rbtospecs/specification/spec_builder_spec.rbwhich is a better name (it tests theSpecBuilderclass, notBuilder).Note that it does not add these compiler flags to the generated podspec, so a project using the generated pod will not have these flags set. I think this is the expected behaviour.