Perform regexp escape on individual words before joining them #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,8 +73,9 @@ def web_search | |||
| end | |||
|
|
|||
| def local_search | |||
| query_regex = @query.join(' ').strip | |||
| query_regex = Regexp.escape(query_regex) unless @use_regex | |||
| query_regex = @query.reduce('') { |result, q| | |||
There was a problem hiding this comment.
Here too you could use an Array.new, and result << (@use_regex ? q : Regexp.escape(q)), then join before stripping.
| @@ -16,7 +16,7 @@ class Search < Command | |||
| def self.options | |||
| [ | |||
| ['--regex', 'Interpret the `QUERY` as a regular expression'], | |||
| ['--full', 'Search by name, summary, and description'], | |||
| ['--full', 'Search by name, summary, description and authors'], | |||
|
👍🏻 with specs and CHANGELOG |
manuyavuz
force-pushed
the
imp/searchPerformance
branch
from
dbc26c8
to
6dbef0c
Compare
|
Good to go from me 🚀 |
segiddins
added a commit
that referenced
this pull request
Oct 25, 2015
Perform regexp escape on individual words before joining them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To complete changes discussed in #8, we need to change Regexp escaping a little.
Specifically, current implementation performs escape after joining all query argument into a string. For example, while running
pod search --full network librarycommand, a string like"network\ library"will be generated (they joined with space character, then whole string is escaped). This cause a problem inside SourcesManager. Because it needs to search for each query word individually and then return an intersection of individual results, it needs to split given query string to get individual words.Proposed implementation performs regexp escape on individual query arguments first, then joins escaped strings with space character.