Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/auth with API KEY #32

Merged
merged 12 commits into from
May 15, 2023
Merged

Feature/auth with API KEY #32

merged 12 commits into from
May 15, 2023

Conversation

btnalexandre
Copy link
Contributor

No description provided.

@btnalexandre
Copy link
Contributor Author

btnalexandre commented Jan 14, 2022

Code coverage 100%

CleanShot 2022-01-14 at 03 01 49@2x

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #32 (3eb0e5e) into develop (73e6b3c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             develop       #32   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        65        74    +9     
===========================================
  Files              6         6           
  Lines            140       152   +12     
===========================================
+ Hits             140       152   +12     
Impacted Files Coverage Δ
src/Client.php 100.00% <100.00%> (ø)
src/Version.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73e6b3c...3eb0e5e. Read the comment docs.

src/Client.php Show resolved Hide resolved
tests/ClientTest.php Outdated Show resolved Hide resolved
@sebfie
Copy link
Contributor

sebfie commented Jan 24, 2022

Il me semble qu'il manque l'essentiel, la mise à jour de la documentation :p

Ici tu fais un tab Recommandé (API KEY) et Déprécié (Tokens)

CleanShot 2022-01-24 at 21 33 32@2x

Tu rajoutes aussi une catégorie : Comment obtenir son API KEY avec des captures d'écran... tout beau.

Copy link
Contributor

@sebfie sebfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La doc

src/Version.php Show resolved Hide resolved
@btnalexandre
Copy link
Contributor Author

Tu rajoutes aussi une catégorie : Comment obtenir son API KEY avec des captures d'écran... tout beau.

Pour ça vaut-il mieux pas update la doc api ?

@sebfie
Copy link
Contributor

sebfie commented Jan 26, 2022

Je prendrai peut etre ta doc et ja la copierai dans la doc api :p Mais il la faut un peu partout c'est trop important !

@btnalexandre
Copy link
Contributor Author

on est good?

@sebfie
Copy link
Contributor

sebfie commented Jan 28, 2022

CleanShot 2022-01-28 at 10 52 02

Je veux en rouge un message, genre : Update janvier 2022. Changement de la méthode d'authentification, à partir de maintenant nous recommandons l'authentification par clée api.

@btnalexandre
Copy link
Contributor Author

bien vu

@btnalexandre
Copy link
Contributor Author

@sebfie c'est ok pour toi?

Copy link
Contributor

@sebfie sebfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'avais oublié d'envoyer ma review...

docs/Tutorials/Get-API-KEY.md Outdated Show resolved Hide resolved
docs/Tutorials/Get-API-KEY.md Outdated Show resolved Hide resolved
docs/Tutorials/Get-API-KEY.md Outdated Show resolved Hide resolved
docs/toc.json Outdated Show resolved Hide resolved
@sebfie sebfie merged commit 33f95ee into develop May 15, 2023
1 check passed
@sebfie sebfie deleted the feature/auth branch May 15, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants