Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for wallet #1772

Merged
merged 9 commits into from
Mar 5, 2019
Merged

Initial commit for wallet #1772

merged 9 commits into from
Mar 5, 2019

Conversation

Schmavery
Copy link
Contributor

This is a rough framework for the wallet app, running on electron + reasonreact + graphql
Exposes a server from the daemon that serves graphql (a single queryable value) from localhost:8080/graphql. The schema of the graphql is generated and checked in on the client side.

The layout itself is basically just a made-up proof of concept right now.

Some work is remaining to hook up CI probably.

Adds opam dependency on:

  • graphql-async.0.9.0
  • graphql-cohttp.0.8.0

Some future work:

@Schmavery Schmavery requested a review from bkase March 1, 2019 21:23
Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make CI do refmt and die if it's not?

@bkase
Copy link
Member

bkase commented Mar 1, 2019

And try to build the daemon to get the schema if it's not too slow

@Schmavery Schmavery force-pushed the feature/wallet-initial-commit branch from f4f8147 to 848db22 Compare March 2, 2019 01:49
@Schmavery
Copy link
Contributor Author

Schmavery commented Mar 4, 2019

I think we should check in the schema.json because it's a clearer definition of the schema that's consumable from non-ocaml code/tooling. I've talked to some other people using this graphql setup and that seems to be the approach they're taking, fwiw.
If this design becomes problematic, we can always change it.

Will add the refmt check though ofc

@Schmavery Schmavery marked this pull request as ready for review March 4, 2019 19:46
@Schmavery Schmavery force-pushed the feature/wallet-initial-commit branch from 2af037f to 61779be Compare March 4, 2019 19:47
@Schmavery Schmavery added the ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR label Mar 5, 2019
@mergify mergify bot merged commit b64735c into master Mar 5, 2019
@mergify mergify bot deleted the feature/wallet-initial-commit branch March 5, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants