Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order expiration time should be set high enough for staggered orders #174

Closed
bitphage opened this issue Jun 2, 2018 · 3 comments
Closed

Order expiration time should be set high enough for staggered orders #174

bitphage opened this issue Jun 2, 2018 · 3 comments
Assignees
@bitphage
Labels
[3] Type: Bug [4] Priority: High

Comments

@bitphage
Copy link
Collaborator

bitphage commented Jun 2, 2018

By default, dexbot uses python-bitshares order expiration time (7 days) which is quite low for staggered orders. Whether order expired, on the next run of the staggered orders worker it will treat expired order as filled and so a reverse order will be placed, effectively selling your funds (same as #170).

So, order expiration time should be set high enough for staggered orders.

Specifications

  • Version: 0.2.7
  • OS:
@bitphage
Copy link
Collaborator Author

bitphage commented Jun 2, 2018

I'm working on this (self-assigning).

bitphage added a commit to bitphage/DEXBot that referenced this issue Jun 2, 2018
@bitphage
Set high order expiration time for staggered orders
8acb1df 
By default, dexbot uses python-bitshares order expiration time (7 days)
which is quite low for staggered orders. Whether order expired, on the
next run of the staggered orders worker it will treat expired order as
filled and so a reverse order will be placed, effectively selling your
funds (same as Codaone#170).

Closes: Codaone#174
@bitphage bitphage mentioned this issue Jun 2, 2018
Merged
@MarkoPaasila
Copy link
Collaborator

Wow I didn't even know that. It should be something like 5 years = 157,680,000 seconds.

@MarkoPaasila
Copy link
Collaborator

And looking at your commit you seem to agree :-). Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bitphage bitphage

Labels
[3] Type: Bug [4] Priority: High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bitphage @MarkoPaasila