Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed clock policy algorithm around delete #31

Merged
merged 1 commit into from
Oct 16, 2022
Merged

fixed clock policy algorithm around delete #31

merged 1 commit into from
Oct 16, 2022

Conversation

Code-Hex
Copy link
Owner

@Code-Hex Code-Hex commented Oct 16, 2022

Fixes #29

Until now, if the reference count was 0, it was assumed not to exist, but the value existed in the ring queue, causing an inconsistency. So I have fixed it to set nil value in the ring queue after deleting a value.

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Merging #31 (55774a8) into main (5301ac8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          520       517    -3     
=========================================
- Hits           520       517    -3     
Impacted Files Coverage Δ
policy/clock/clock.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Code-Hex Code-Hex merged commit ccf9cd9 into main Oct 16, 2022
@Code-Hex Code-Hex deleted the fix/issue-29 branch October 16, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clock policy: Not show all the page with sequential access pattern
1 participant