Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commit error handling. #4

Merged
merged 1 commit into from Nov 11, 2018
Merged

Fix commit error handling. #4

merged 1 commit into from Nov 11, 2018

Conversation

xaicron
Copy link
Contributor

@xaicron xaicron commented Nov 9, 2018

Hi, Code-Hex.

This module is very cool.
but, I found a small problem.

That is tx.Commit() may return an error.
I want to catch it.

Please check it.
Thank you.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 77

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.429%
Totals Coverage Status
Change from base Build 76: 0.0%
Covered Lines: 85
Relevant Lines: 119
💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 77

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.429%
Totals Coverage Status
Change from base Build 76: 0.0%
Covered Lines: 85
Relevant Lines: 119
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 77

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.429%
Totals Coverage Status
Change from base Build 76: 0.0%
Covered Lines: 85
Relevant Lines: 119
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 77

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.429%
Totals Coverage Status
Change from base Build 76: 0.0%
Covered Lines: 85
Relevant Lines: 119
💛 - Coveralls

Code-Hex
Code-Hex approved these changes Nov 11, 2018
View reviewed changes
Copy link
Owner

@Code-Hex Code-Hex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@Code-Hex Code-Hex merged commit a6e79c1 into Code-Hex:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Code-Hex Code-Hex Code-Hex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xaicron @coveralls @Code-Hex