Drop dependency on reflect #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 2637 2635 -2
=========================================
- Hits 2637 2635 -2 ☔ View full report in Codecov by Sentry. |
Code-Hex
reviewed
Dec 16, 2023
period.go
Outdated
| case []byte: | ||
| return ParseISO[T](string(v)) | ||
| return ParseISO[T](string(*(*[]byte)(argPtr))) |
There was a problem hiding this comment.
Can we use this?
https://pkg.go.dev/unsafe#String
There was a problem hiding this comment.
Certainly it can. I've updated the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the code used
reflectpackage to access a variable with bound~string. This can be improved by using unsafe.Pointer trick so that synchro can have no dependency onreflect.