Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed socket.go to do not release the shared devices pointer #65

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

Code-Hex
Copy link
Owner

Which issue(s) this PR fixes:

Fixes #13

Additional documentation

@cfergeau suggested why this change is necessary.

It is owned and maintained by the VMM. As a caller, we should not release it. If we do, we'll make it a dangling pointer.

@cfergeau
Copy link
Contributor

Might be better to directly cherry-pick the commit from kata-container/vz to keep authorship, commit log, ...

@Code-Hex Code-Hex merged commit 5a0ab51 into master Oct 12, 2022
@Code-Hex Code-Hex deleted the fix/socket branch October 12, 2022 13:41
@Code-Hex
Copy link
Owner Author

@cfergeau Oh, I didn't see your comment. Right, I fix the commit (but I don't know how to it from forked repository...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zsh: segmentation fault ./virtualization
2 participants