Add VZVirtualMachineConfiguration:SocketDevices and VZVirtualMachineConfiguration:NetworkDevices #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since only a single VZVirtioSocketDevice is allowed per virtual machine instance, it's useful to be able to check whether one is already set or not in the VZVirtualMachineConfiguration object. This fixes Code-Hex#81
Code-Hex
reviewed
Oct 19, 2022
| @@ -112,3 +120,57 @@ func TestIssue43(t *testing.T) { | |||
| } | |||
| }) | |||
| } | |||
|
|
|||
| func TestIssue81(t *testing.T) { | |||
There was a problem hiding this comment.
The meaning of TestIssueXXX is used to indicate that the bug has been fixed, in line with the official Go repository. (In fact, it is created for each file, but because of the volume, it is created as a single function. e.g. issue21104_test.go)
This is not a bug and should be created as a functional test.
I will correct this on our side for clarity later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since only a single VZVirtioSocketDevice is allowed per virtual machine
instance, it's useful to be able to check whether one is already set or not
in the VZVirtualMachineConfiguration object.
This fixes #81
Which issue(s) this PR fixes:
Fixes #
Additional documentation