console: Don't return error for non-existing files #83
Conversation
cfergeau
force-pushed
the
console
branch
2 times, most recently
from
92d0972
to
b7b9303
Compare
|
The failure on the macOS11 builders is not strictly related to this PR |
|
Probably not the best fix, but good enough to get the tests to pass ;) |
|
@cfergeau Create the issue first, as described in the contribution guide.
|
NewFileSerialPortAttachment was mistakenly used in the 'NewSharedDirectory' test
When using NewFileSerialPortAttachment(), the virtualization framework will create the log file if it does not exist yet. If a directory in the path is invalid, an error will be returned by the virtualization framework, not an exception.This means we don't need to check this in Code-Hex/vz. This commit removes the file existence check which was added in commit 117c12a. This fixes Code-Hex#84
This was missing from some of your recent commits. I assumed this was no longer a strict requirement. |
When using NewFileSerialPortAttachment(), the virtualization framework will
create the log file if it does not exist yet.
commit 117c12a added a file existence check to this API, which is incorrect.
Fixes #84